Bug #47690 Service interface skip of 'PERFORMANCE_SCHEMA' database incomplete
Submitted: 28 Sep 2009 21:32 Modified: 22 Feb 2010 21:13
Reporter: Chuck Bell Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Backup Severity:S3 (Non-critical)
Version:6.0 OS:Any
Assigned to: Chuck Bell CPU Architecture:Any

[28 Sep 2009 21:32] Chuck Bell 
Description:
The si_objects code is partially coded to ignore the PERFORMANCE_SCHEMA database on backup. This database should be treated like the INFORMATION_SCHEMA and mysql database such that it is excluded from the list of databases included in the backup image.

How to repeat:
Code inspection.

Suggested fix:
Add PERFORMANCE_SCHEMA on all internal database checks.
[2 Oct 2009 19:50] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/85600

2877 Chuck Bell	2009-10-02
      BUG#47690 : Service interface skip of 'PERFORMANCE_SCHEMA' database incomplete
      
      The si_objects code is partially coded to ignore the PERFORMANCE_SCHEMA 
      database on backup. This database should be treated like the 
      INFORMATION_SCHEMA and mysql database such that it is excluded 
      from the list of databases included in the backup image and
      for all access checks.
      
      This patch adds the 'performance_schema' clause to all of the where 
      clauses where missing.
      
      Note: A test case cannot be constructed until the performance 
      schema code is pushed. This patch will ensure backup will not fail 
      when that work is complete.
      
      ******
      BUG#47690 : Service interface skip of 'PERFORMANCE_SCHEMA' database incomplete
      
      The si_objects code is partially coded to ignore the PERFORMANCE_SCHEMA 
      database on backup. This database should be treated like the 
      INFORMATION_SCHEMA and mysql database such that it is excluded 
      from the list of databases included in the backup image and
      for all access checks.
      
      This patch adds the 'performance_schema' clause to all of the where 
      clauses where missing.
      
      Note: A test case cannot be constructed until the performance 
      schema code is pushed. This patch will ensure backup will not fail 
      when that work is complete.
     @ sql/si_objects.cc
        Added 'performance_schema' to all internal database name
        checks.
        ******
        Added 'performance_schema' to all internal database name
        checks.
[2 Oct 2009 19:53] Chuck Bell 
What the? Please use latest patch to review. I don't know what caused the double commit comments. Weird.
[2 Oct 2009 19:53] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/85601

2877 Chuck Bell	2009-10-02
      BUG#47690 : Service interface skip of 'PERFORMANCE_SCHEMA' database incomplete
      
      The si_objects code is partially coded to ignore the PERFORMANCE_SCHEMA 
      database on backup. This database should be treated like the 
      INFORMATION_SCHEMA and mysql database such that it is excluded 
      from the list of databases included in the backup image and
      for all access checks.
      
      This patch adds the 'performance_schema' clause to all of the where 
      clauses where missing.
      
      Note: A test case cannot be constructed until the performance 
      schema code is pushed. This patch will ensure backup will not fail 
      when that work is complete.
     @ sql/si_objects.cc
        Added 'performance_schema' to all internal database name
        checks.
[15 Oct 2009 14:57] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/86998

2877 Chuck Bell	2009-10-15
      BUG#47690 : Service interface skip of 'PERFORMANCE_SCHEMA' database incomplete
      
      The si_objects code is partially coded to ignore the PERFORMANCE_SCHEMA 
      database on backup. This database should be treated like the 
      INFORMATION_SCHEMA and mysql database such that it is excluded 
      from the list of databases included in the backup image and
      for all access checks.
      
      This patch adds the 'performance_schema' clause to all of the where 
      clauses where missing.
      
      Note: A test case cannot be constructed until the performance 
      schema code is pushed. This patch will ensure backup will not fail 
      when that work is complete.
     @ sql/si_objects.cc
        Added 'performance_schema' to all internal database name
        checks.
[19 Oct 2009 15:56] Ingo Strüwing 
Approved. No comments.
[20 Feb 2010 9:19] Bugs System 
Pushed into 6.0.14-alpha (revid:ingo.struewing@sun.com-20100218152520-s4v1ld76bif06eqn) (version source revid:ingo.struewing@sun.com-20100119103538-wtp5alpz4p2jayl5) (merge vers: 6.0.14-alpha) (pib:16)
[22 Feb 2010 21:13] Paul DuBois 
Does not appear in any released version. No changelog entry needed.