MySQL Bugs: #46672: InnoDB plugin: consider porting to the plugin some bugfixes made to the builtin

Bug #46672	InnoDB plugin: consider porting to the plugin some bugfixes made to the builtin
Submitted:	12 Aug 2009 10:28	Modified:	24 Mar 2010 16:51
Reporter:	Guilhem Bichot	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: InnoDB Plugin storage engine	Severity:	S2 (Serious)
Version:	5.1	OS:	Any
Assigned to:	Satya B	CPU Architecture:	Any

Description:
This bug report is for Oracle/Innobase.

Some fix has recently been made to the InnoDB builtin, but not to the InnoDB plugin: the fix for BUG#18828 "If InnoDB runs out of undo slots, it returns misleading 'table is full'".
The patch for this bug can be viewed by branching 5.1:
 bzr branch https://code.launchpad.net/~mysql/mysql-server/mysql-5.1
and then doing:
 bzr diff -c 'revid:satya.bn@sun.com-20090724064506-axz1so8beem1g1kz'

The fix is present in storage/innobase of 5.1, but we (Sun/MySQL) have *not* ported it to storage/innodb_plugin, we leave it up to Oracle/Innobase to do it (if porting is appropriate; otherwise let us know, if the bugfix is wrong, is not needed...).

How to repeat:
.

Vasil will doublecheck if we missed something when he's back from vacation.

The patch has been ported into plugin 1.0.4.

r5798 in our internal repo.

Pushed into 5.1.41, 5.5.0-beta. Only affecting InnoDB plugin.

Noted in 5.1.41, 5.5.0 changelogs.

If InnoDB reached its limit on the number of concurrent transactions 
(1023), it wrote a descriptive message to the error log but returned
a misleading error message to the client, or an assertion failure
occurred.

Paul, please update the release note to specify "InnoDB plugin" instead of simply "InnoDB". This has been in the non-plugin InnoDB for a while.

James, done.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/103140

3128 Konstantin Osipov	2010-03-13
      A review comment for the fix for Bug#46672.
      Remove unnecessary need_reopen loops.

Pushed into 6.0.14-alpha (revid:alik@sun.com-20100324081249-yfwol7qtcek6dh7w) (version source revid:alik@sun.com-20100324081113-kc7x1iytnplww91u) (merge vers: 6.0.14-alpha) (pib:16)

Pushed into 5.5.4-m3 (revid:alik@sun.com-20100324081056-6bndv6f0nrvbblhp) (version source revid:alik@sun.com-20100324081056-6bndv6f0nrvbblhp) (merge vers: 5.5.4-m3) (pib:16)

Pushed into mysql-next-mr (revid:alik@sun.com-20100324081159-5b8juv8ldiqwce8v) (version source revid:alik@sun.com-20100324081105-y72rautcea375zxm) (pib:16)

Noted in 6.0.14 changelog.

Already fixed in earlier 5.5.x.