Bug #45286 compilation warnings on mysql-5.0-bugteam on MacOSX

Submitted: 3 Jun 2009 8:10 Modified: 12 Aug 2009 15:48
Reporter: Georgi Kodinov Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:5.0+ OS:MacOS
Assigned to: Georgi Kodinov CPU Architecture:Any
Tags: ProdEngPB2

[3 Jun 2009 8:10] Georgi Kodinov 
Description:
There are 17 warnings compiling MySQL on MacOSX platforms:
*** At line 2741 of the build log, in bind.c:704:
bind.c:704: warning: comparison is always true due to limited range of data type

*** At line 2745 of the build log, in display.c:1891:
display.c:1891: warning: comparison is always true due to limited range of data type

*** At line 4146 of the build log, in ctype.c:330:
ctype.c:330: warning: pointer targets in passing argument 3 of 'cs->cset->mb_wc' differ in signedness

*** At line 4147 of the build log, in ctype.c:330:
ctype.c:330: warning: pointer targets in passing argument 4 of 'cs->cset->mb_wc' differ in signedness

*** At line 4511 of the build log, in user.r:204:
user.r:204: warning: can't find font `C'

*** At line 4513 of the build log, in user.r:751:
user.r:751: warning [p 15, 7.8i]: can't break line

*** At line 4514 of the build log, in user.r:761:
user.r:761: warning [p 15, 10.0i]: can't break line

*** At line 4515 of the build log, in user.r:771:
user.r:771: warning [p 16, 2.7i]: can't break line

*** At line 4516 of the build log, in user.r:811:
user.r:811: warning [p 16, 9.3i]: can't break line

*** At line 4517 of the build log, in user.r:813:
user.r:813: warning [p 16, 9.5i]: cannot adjust line

*** At line 4518 of the build log, in user.r:1111:
user.r:1111: warning: indent cannot be negative

*** At line 7050 of the build log, in ctype.c:330:
ctype.c:330: warning: pointer targets in passing argument 3 of 'cs->cset->mb_wc' differ in signedness

*** At line 7051 of the build log, in ctype.c:330:
ctype.c:330: warning: pointer targets in passing argument 4 of 'cs->cset->mb_wc' differ in signedness

*** At line 7588 of the build log, in ctype.c:330:
ctype.c:330: warning: pointer targets in passing argument 3 of 'cs->cset->mb_wc' differ in signedness

*** At line 7589 of the build log, in ctype.c:330:
ctype.c:330: warning: pointer targets in passing argument 4 of 'cs->cset->mb_wc' differ in signedness

*** At line 7771 of the build log, in mysqldump.c:3125:
mysqldump.c:3125: warning: pointer targets in passing argument 1 of 'include_table' differ in signedness

*** At line 7772 of the build log, in mysqldump.c:3146:
mysqldump.c:3146: warning: pointer targets in passing argument 1 of 'include_table' differ in signedness

How to repeat:
check pb2 output for 5.0-bugteam

Suggested fix:
Take care of the warnings
[5 Jun 2009 12:08] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/75701

2767 Georgi Kodinov	2009-06-05
      Bug #45286: compilation warnings on mysql-5.0-bugteam on MacOSX
      
      Fixed the 5.0-bugteam MacOSX warnings.
     @ client/mysqldump.c
        Bug #45286: typecasts
     @ cmd-line-utils/readline/bind.c
        Bug #45286: use variable of right type
     @ cmd-line-utils/readline/display.c
        Bug #45286: use variable of right type
     @ dbug/user.r
        Bug #45286: no warnings in generating man pages
     @ strings/ctype.c
        Bug #45286: typecasts
[5 Jun 2009 13:44] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/75706

2931 Georgi Kodinov	2009-06-05
      Bug #45286: compilation warnings on mysql-5.0-bugteam on MacOSX
      
      Merged the 5.0 fix to 5.1 and fixed the 5.1 specific warnings.
[5 Jun 2009 15:17] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/75715

2768 Georgi Kodinov	2009-06-05
      Bug #45286: compilation warnings on mysql-5.0-bugteam on MacOSX
      
      Implemented a way to circumvent the always true comparison by
      having nested macros (as suggested on review).
[5 Jun 2009 16:24] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/75725

2769 Georgi Kodinov	2009-06-05
      Addendum to Bug #45286 : implement reviewer's remarks.
[6 Jun 2009 13:08] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/75779

2932 Tatiana A. Nurnberg	2009-06-06
      Addendum to Bug #45286: backport macro name form other tree
      
      use same (slightly unwieldy) name in all trees; fix before this version goes "public".
      bless ctype to avoid upmerge conflict, le sigh.
[16 Jun 2009 8:33] Bugs System 
Pushed into 5.0.84 (revid:gkodinov@mysql.com-20090616082753-kwe0l8uoictxhojf) (version source revid:azundris@mysql.com-20090605212937-9kcqi5zjat2f2awm) (merge vers: 5.0.83) (pib:6)
[16 Jun 2009 11:04] Bugs System 
Pushed into 5.1.36 (revid:joro@sun.com-20090616102155-3zhezogudt4uxdyn) (version source revid:azundris@mysql.com-20090606160558-utmxhnb88ur1vcra) (merge vers: 5.1.36) (pib:6)
[17 Jun 2009 19:24] Bugs System 
Pushed into 5.4.4-alpha (revid:alik@sun.com-20090616183122-chjzbaa30qopdra9) (version source revid:azundris@mysql.com-20090606160423-aym8s5rn51nmg387) (merge vers: 6.0.12-alpha) (pib:11)
[12 Aug 2009 15:48] Paul DuBois 
Noted in 5.0.84, 5.1.36, 5.4.4 changelogs.

Compiler warnings on Mac OS X were fixed.
[26 Aug 2009 13:46] Bugs System 
Pushed into 5.1.37-ndb-7.0.8 (revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (version source revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)
[26 Aug 2009 13:46] Bugs System 
Pushed into 5.1.37-ndb-6.3.27 (revid:jonas@mysql.com-20090826105955-bkj027t47gfbamnc) (version source revid:jonas@mysql.com-20090826105955-bkj027t47gfbamnc) (merge vers: 5.1.37-ndb-6.3.27) (pib:11)
[26 Aug 2009 13:48] Bugs System 
Pushed into 5.1.37-ndb-6.2.19 (revid:jonas@mysql.com-20090825194404-37rtosk049t9koc4) (version source revid:jonas@mysql.com-20090825194404-37rtosk049t9koc4) (merge vers: 5.1.37-ndb-6.2.19) (pib:11)
[27 Aug 2009 16:32] Bugs System 
Pushed into 5.1.35-ndb-7.1.0 (revid:magnus.blaudd@sun.com-20090827163030-6o3kk6r2oua159hr) (version source revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)
[7 Oct 2009 18:36] Paul DuBois 
The 5.4 fix has been pushed to 5.4.2.

Portions of this website are copyright © 2001, 2002 The PHP Group

Page generated in 0.051 sec. using MySQL 8.4.7-u6-cloud

Timestamp references displayed by the system are UTC.
Content reproduced on this site is the property of the respective copyright holders.
It is not reviewed in advance by Oracle and does not necessarily represent the opinion of Oracle or any other party.