Bug #44920 MTR2 is not processing master.opt input properly on Windows
Submitted: 17 May 2009 19:13 Modified: 2 Oct 2009 5:55
Reporter: Patrick Crews Email Updates:
Status: Duplicate Impact on me:
None 
Category:Tools: MTR / mysql-test-run Severity:S3 (Non-critical)
Version:5.1+ OS:Windows
Assigned to: Bjørn Munch CPU Architecture:Any
Tags: disabled, init_connect, master.opt, MTR2, server options, windows

[17 May 2009 19:13] Patrick Crews
Description:
MTR2 is not properly processing master.opt input on Windows (using regular command line - not Cygwin).

The failures return values such as: mysqld.exe: Too many arguments (first extra is '@a='a\0c'') - from main.init_connect.test.

This problem does *not* occur when using MTR_VERSION=1

This is occurring as the code to process opt file input differs markedly between versions

How to repeat:
On Windows' regular command line, run the following test:

perl ./mysql-test-run.pl --force init_connect

Observe the failure output as noted above.

Suggested fix:
Alter lib/mtr_cases.pm's, process_opts_file() to handle opt file input as effectively as lib/v1/mtr_io.pl's mtr_get_opts_from_file().

While the MTR1 version is a bit hacky, it *does* work.  We need to ensure that we incorporate what it does (perhaps in a better form) into MTR2's code for processing <test>-master.opt files.

There is a lot of code devoted to handling the spaces in an option as well as specific code for this scenario in the MTR1 code.
[18 May 2009 16:52] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/74399

2886 Patrick Crews	2009-05-18
      Bug#44920 - MTR2 is not processing master.opt input properly on Windows
      
      Disabling these two tests as they are affected by this bug / causing PB2 failures
      on Windows platforms.  Can always disable via include/not_windows.inc if
      the bug fix looks like it will take some time.
[18 May 2009 17:08] Patrick Crews
Patch submitted is only to disabled the tests affected by this bug:  main.init_connect and rpl.rpl_init_slave
[22 May 2009 23:45] Luis Soares
See also BUG#44406.
[28 May 2009 8:15] Bugs System
Pushed into 5.1.36 (revid:joro@sun.com-20090528073639-yohsb4q1jzg7ycws) (version source revid:patrick.crews@sun.com-20090518165306-el5lj99zwo1yc2p6) (merge vers: 5.1.36) (pib:6)
[28 May 2009 18:59] Magnus Blåudd
Wonder why it hasn't shown up earlier?
[28 May 2009 19:19] Patrick Crews
I think it didn't show up until recently as PB1 was using Windows with Cygwin, which doesn't display this bug and attention to PB2 didn't start getting as 'focused' until the switchover was near ;-)
[12 Jun 2009 13:40] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/76185

2936 Patrick Crews	2009-06-12
      Bug#44920: MTR2 is not processing master.opt input properly on Windows
      
      Re-enabled tests main.init_connect and rpl.rpl_init_slave.test for non-Windows
      platforms.
      
      Please remove this code upon fixing the bug.
[12 Jun 2009 13:43] Patrick Crews
Re-enabled init_connect and rpl.rpl_init_slave on non-Windows platform by adding some code to the tests and removing the disabled.def entries.

Please remove this code from these two tests upon fixing this bug.  Placing the bug back into 'Verified' status
[12 Jun 2009 13:43] Patrick Crews
Re-enabled init_connect and rpl.rpl_init_slave on non-Windows platform by adding some code to the tests and removing the disabled.def entries.

Please remove this code from these two tests upon fixing this bug.  Placing the bug back into 'Verified' status
[16 Jun 2009 11:04] Bugs System
Pushed into 5.1.36 (revid:joro@sun.com-20090616102155-3zhezogudt4uxdyn) (version source revid:joro@sun.com-20090612140424-yiklmz5v6ihokc6a) (merge vers: 5.1.36) (pib:6)
[17 Jun 2009 19:22] Bugs System
Pushed into 5.4.4-alpha (revid:alik@sun.com-20090616183122-chjzbaa30qopdra9) (version source revid:patrick.crews@sun.com-20090518171547-91x10fcygf4j71cn) (merge vers: 6.0.12-alpha) (pib:11)
[6 Jul 2009 22:21] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/78064

3006 Patrick Crews	2009-07-06
      Bug#44920: MTR2 is not processing master.opt input properly on Windows.
      
      Had attempted to disable this test on Windows only, but the nature of this bug
      does not allow for this.  The master.opt file is processed before anything in 
      in the actual test.  As a result, we must use disabled.def files to ensure
      these tests are skipped on the problematic platforms.
      
      Removed Windows-only code and updated the proper disabled.def files accordingly.
[8 Jul 2009 13:30] Bugs System
Pushed into 5.1.37 (revid:joro@sun.com-20090708131116-kyz8iotbum8w9yic) (version source revid:joro@sun.com-20090707144419-dcz527rmbjekaki8) (merge vers: 5.1.37) (pib:11)
[9 Jul 2009 7:37] Bugs System
Pushed into 5.1.37 (revid:joro@sun.com-20090708131116-kyz8iotbum8w9yic) (version source revid:joro@sun.com-20090707144419-dcz527rmbjekaki8) (merge vers: 5.1.37) (pib:11)
[10 Jul 2009 11:20] Bugs System
Pushed into 5.4.4-alpha (revid:anozdrin@bk-internal.mysql.com-20090710111017-bnh2cau84ug1hvei) (version source revid:patrick.crews@sun.com-20090706222909-7ccnl7np5g8f9tbe) (merge vers: 5.4.4-alpha) (pib:11)
[16 Jul 2009 9:21] Bjørn Munch
This caused by Bug #43005, which is now in Patch Queued including an undo of the disabling.
[26 Aug 2009 13:46] Bugs System
Pushed into 5.1.37-ndb-7.0.8 (revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (version source revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)
[26 Aug 2009 13:46] Bugs System
Pushed into 5.1.37-ndb-6.3.27 (revid:jonas@mysql.com-20090826105955-bkj027t47gfbamnc) (version source revid:jonas@mysql.com-20090826105955-bkj027t47gfbamnc) (merge vers: 5.1.37-ndb-6.3.27) (pib:11)
[26 Aug 2009 13:48] Bugs System
Pushed into 5.1.37-ndb-6.2.19 (revid:jonas@mysql.com-20090825194404-37rtosk049t9koc4) (version source revid:jonas@mysql.com-20090825194404-37rtosk049t9koc4) (merge vers: 5.1.37-ndb-6.2.19) (pib:11)
[27 Aug 2009 16:32] Bugs System
Pushed into 5.1.35-ndb-7.1.0 (revid:magnus.blaudd@sun.com-20090827163030-6o3kk6r2oua159hr) (version source revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)
[31 Aug 2009 12:29] Andrei Elkin
Test case rpl_init_slave is still disabled in  mysql-5.1-bugteam tree.
Bjorn, could you please sort it out?
If the test should stay disabled there must be a different than the current bug
reason.
Thanks!
[31 Aug 2009 12:34] Bjørn Munch
It's still disabled there for the simple reason that the bug fix for Bug #43005 still hasn't propagated outside the -mtr trees.  I'm hoping to have -mtr merged to the main trees very soon now.
[1 Oct 2009 23:10] Bugs System
No feedback was provided for this bug for over a month, so it is
being suspended automatically. If you are able to provide the
information that was originally requested, please do so and change
the status of the bug back to "Open".
[2 Oct 2009 5:56] Bjørn Munch
Duplicate of Bug #43005, as previously noted.