Bug #44567 ndbrequire() predicate assign to left arg. instead of checking for Equal
Submitted: 30 Apr 2009 6:46 Modified: 7 May 2009 15:50
Reporter: Ole John Aske Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Cluster: Cluster (NDB) storage engine Severity:S3 (Non-critical)
Version:all OS:Any
Assigned to: Ole John Aske CPU Architecture:Any

[30 Apr 2009 6:46] Ole John Aske
Description:
There are several missuse of '=' (Assign) instead of '==' in nbrequire in:

dbdih/DbdihMain.cpp:  ndbrequire(cmasterdihref = reference());
dbdih/DbdihMain.cpp:  ndbrequire(masterNodeId = cmasterNodeId);
dbdih/DbdihMain.cpp:  ndbrequire(c_lcpState.m_masterLcpDihRef = req->senderRef);

If the (intended) ndbrequires are true, these typos are harmless - However, they may cause unexpected behaviour if the are not.

How to repeat:
Found during code inspection - No (Known) errors related to this.
[30 Apr 2009 6:57] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/73074

2877 Ole John Aske	2009-04-30
      Fix for bug#44567, typo in ndbrequire() predicates.
[30 Apr 2009 7:09] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/73076

2878 Ole John Aske	2009-04-30
      Fix for bug#44567, typo in ndbrequire() predicates.
[30 Apr 2009 7:10] Bugs System
Pushed into 5.1.32-ndb-7.0.6 (revid:ole.john.aske@sun.com-20090430070921-dmb0cz6oygecs6np) (version source revid:ole.john.aske@sun.com-20090430070921-dmb0cz6oygecs6np) (merge vers: 5.1.32-ndb-7.0.6) (pib:6)
[30 Apr 2009 7:30] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/73079

2911 Ole John Aske	2009-04-30
      Fix for bug#44567, typo in ndbrequire() predicates. -> telco 6.2
[30 Apr 2009 7:33] Bugs System
Pushed into 5.1.32-ndb-6.2.18 (revid:ole.john.aske@sun.com-20090430072944-1syky0gb3fiuj5az) (version source revid:ole.john.aske@sun.com-20090430072944-1syky0gb3fiuj5az) (merge vers: 5.1.32-ndb-6.2.18) (pib:6)
[30 Apr 2009 7:45] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/73082

2940 Ole John Aske	2009-04-30 [merge]
      Fix for bug#44567, typo in ndbrequire() predicates. -> telco 6.3
[30 Apr 2009 7:47] Bugs System
Pushed into 5.1.32-ndb-6.3.25 (revid:ole.john.aske@sun.com-20090430074512-t5y5wy08dhbkiik7) (version source revid:ole.john.aske@sun.com-20090430074512-t5y5wy08dhbkiik7) (merge vers: 5.1.32-ndb-6.3.25) (pib:6)
[30 Apr 2009 8:51] Bugs System
Pushed into 5.1.32-ndb-7.0.6 (revid:ole.john.aske@sun.com-20090430084504-2c8iheeuc631njs5) (version source revid:ole.john.aske@sun.com-20090430084504-2c8iheeuc631njs5) (merge vers: 5.1.32-ndb-7.0.6) (pib:6)
[7 May 2009 15:50] Jon Stephens
Documented bugfix in the NDB-6.2.18, 6.3.25, and 7.0.6 changelogs as follows:

        Inspection of the code revealed that several assignment
        operators (=) were used instead of comparison operators (==) in
        DbdihMain.cpp.