Bug #44484 innochecksum doesn't output filename correctly

• Submitted: 26 Apr 2009 18:47
• Modified: 26 Jun 2009 2:19
• Reporter: Andrew Hutchings
• Status: Closed
• Category: MySQL Server: InnoDB storage engine
• Severity: S3 (Non-critical)
• Version: 5.1,5.4
• OS: Any
• Assigned to: Jim Winstead
• CPU Architecture: Any
• Tags: Contribution

[26 Apr 2009 18:47] Andrew Hutchings

Description:
innochecksum spits out argv[1] as the filename.  This will display the first parameter instead of the filename if the parameter is used before the filename (as specified when run with no parameters).

How to repeat:
Run innochecksum -v ibdata1

file -v= 10485760 bytes (640 pages)...
checking pages in range 0 to 639

Suggested fix:
Change to argv[optind]

Patch will be attached shortly

[26 Apr 2009 18:47] Andrew Hutchings

Fix for this problem

Attachment: mysql-5.1.34-innochecksum.diff (application/octet-stream, text), 569 bytes.

[27 Apr 2009 14:44] Mikhail Izioumtchenko

Vasil, could you have a look?

[5 May 2009 18:08] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/73419

2886 Jim Winstead	2009-05-05
      Fix incorrect filename in verbose output of innochecksum. (Bug #44484,
      patch contributed by Andrew Hutchings)
      modified:
        extra/innochecksum.c

[13 May 2009 16:09] Jim Winstead

Patch queued to 5.1-bugteam, will be merged up from there.

[28 May 2009 8:17] Bugs System

Pushed into 5.1.36 (revid:[e-mail]-20090528073639-yohsb4q1jzg7ycws) (version source revid:[e-mail]-20090512212719-mjc8fz4q3ewvr4yd) (merge vers: 5.1.35) (pib:6)

[1 Jun 2009 19:26] Paul DuBois

Noted in 5.1.36 changelog.

innochecksum could incorrectly determine the input file name from the
arguments. 

Setting report to NDI pending push into 6.0.x.

[17 Jun 2009 19:24] Bugs System

Pushed into 5.4.4-alpha (revid:[e-mail]-20090616183122-chjzbaa30qopdra9) (version source revid:[e-mail]-20090514020104-7u5cqf5cyywa8aks) (merge vers: 6.0.12-alpha) (pib:11)

[26 Jun 2009 2:19] Paul DuBois

Noted in 5.4.4 changelog.

[12 Aug 2009 22:34] Paul DuBois

Noted in 5.4.2 changelog because next 5.4 version will be 5.4.2 and not 5.4.4.

[15 Aug 2009 1:52] Paul DuBois

Ignore previous comment about 5.4.2.

[26 Aug 2009 13:46] Bugs System

Pushed into 5.1.37-ndb-7.0.8 (revid:[e-mail]-20090826132541-yablppc59e3yb54l) (version source revid:[e-mail]-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)

[26 Aug 2009 13:46] Bugs System

Pushed into 5.1.37-ndb-6.3.27 (revid:[e-mail]-20090826105955-bkj027t47gfbamnc) (version source revid:[e-mail]-20090826105955-bkj027t47gfbamnc) (merge vers: 5.1.37-ndb-6.3.27) (pib:11)

[26 Aug 2009 13:48] Bugs System

Pushed into 5.1.37-ndb-6.2.19 (revid:[e-mail]-20090825194404-37rtosk049t9koc4) (version source revid:[e-mail]-20090825194404-37rtosk049t9koc4) (merge vers: 5.1.37-ndb-6.2.19) (pib:11)

[27 Aug 2009 16:33] Bugs System

Pushed into 5.1.35-ndb-7.1.0 (revid:[e-mail]-20090827163030-6o3kk6r2oua159hr) (version source revid:[e-mail]-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)

[7 Oct 2009 20:24] Paul DuBois

The 5.4 fix has been pushed to 5.4.2.