Bug #44424 mysqldump doesn't output localized 'completed' time

• Submitted: 23 Apr 2009 10:06
• Modified: 26 Jun 2009 2:20
• Reporter: Franco A.
• Status: Closed
• Category: MySQL Server: mysqldump Command-line Client
• Severity: S3 (Non-critical)
• Version: 5.1.34/6.0
• OS: Any
• Assigned to: Jim Winstead
• CPU Architecture: Any
• Tags: Contribution, mysqldump

[23 Apr 2009 10:06] Franco A.

Description:
mysqldump seems to output utc time instead of local time at the end of dump

How to repeat:
I'm in Italy and it's now 2009-04-23 12:04

>mysqldump -u user --no-data dbname

-- MySQL dump 10.13  Distrib 5.1.34, for Win32 (ia32)
--
-- Host: localhost    Database: prototi_coge
-- ------------------------------------------------------
-- Server version	5.1.34-community

...
...
...

-- Dump completed on 2009-04-23 10:02:33

[23 Apr 2009 22:27] MySQL Verification Team

Thank you for the bug report. Please read the Manual at:

http://dev.mysql.com/doc/refman/5.1/en/mysqldump.html

"--tz-utc

This option enables TIMESTAMP columns to be dumped and reloaded between servers in different time zones. mysqldump sets its connection time zone to UTC and adds SET TIME_ZONE='+00:00' to the dump file. Without this option, TIMESTAMP columns are dumped and reloaded in the time zones local to the source and destination servers, which can cause the values to change. --tz-utc also protects against changes due to daylight saving time. --tz-utc is enabled by defaul..."

[24 Apr 2009 7:41] Franco A.

Maybe I didn't explain the problem well:
the mismatch with dates does not happen in dumped data but on the last comment line where mysqldump outputs "Dump completed on xxxxxx". This date on my system is two hours before the current time.
This is not a big problem for sure, I just wanted to point it out, so that it can be corrected in a future release.
Thanks

[24 Apr 2009 20:56] MySQL Verification Team

Thank you for the feedback.

-- Dump completed on 2009-04-24 20:53:12
miguel@txg:~/dbs/6.0$ date
Fri Apr 24 17:53:17 BRT 2009
miguel@txg:~/dbs/6.0$ date -u
Fri Apr 24 20:53:22 UTC 2009
miguel@txg:~/dbs/6.0$

[27 Apr 2009 3:29] Andrew Hutchings

Fix for this bug

Attachment: mysql-5.1.34-bug-44424.diff (application/octet-stream, text), 752 bytes.

[27 Apr 2009 3:30] Andrew Hutchings

In mf_getdate the test for GETDATE_GMT was inverted, so by default you would get GMT time.  My patch reverses this again.

[7 May 2009 18:18] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/73605

2737 Jim Winstead	2009-05-07
      The get_date() function in mysys interpreted the GETDATE_GMT option
      backwards, which resulted in the incorrect time being reported at the
      end of mysqldump. (Bug #44424, patch by Andrew Hutchings)
      modified:
        mysys/mf_getdate.c

[12 May 2009 21:27] Jim Winstead

Queued to 5.0-bugteam, will be merged to later versions from there.

[28 May 2009 7:41] Bugs System

Pushed into 5.0.83 (revid:[e-mail]-20090528073529-q9b8s60vlpu28fny) (version source revid:[e-mail]-20090507181707-2f5ra8lu6wzw7m9b) (merge vers: 5.0.82) (pib:6)

[28 May 2009 8:20] Bugs System

Pushed into 5.1.36 (revid:[e-mail]-20090528073639-yohsb4q1jzg7ycws) (version source revid:[e-mail]-20090513154800-ae963ppyd254q86j) (merge vers: 5.1.35) (pib:6)

[1 Jun 2009 20:29] Paul DuBois

Noted in 5.0.83, 5.1.36 changelogs.

Incorrect time was reported at the end of mysqldump output.

Setting report to NDI pending push into 6.0.x.

[17 Jun 2009 19:27] Bugs System

Pushed into 5.4.4-alpha (revid:[e-mail]-20090616183122-chjzbaa30qopdra9) (version source revid:[e-mail]-20090514020104-7u5cqf5cyywa8aks) (merge vers: 6.0.12-alpha) (pib:11)

[26 Jun 2009 2:20] Paul DuBois

Noted in 5.4.4 changelog.

[12 Aug 2009 22:34] Paul DuBois

Noted in 5.4.2 changelog because next 5.4 version will be 5.4.2 and not 5.4.4.

[15 Aug 2009 1:52] Paul DuBois

Ignore previous comment about 5.4.2.

[26 Aug 2009 13:46] Bugs System

Pushed into 5.1.37-ndb-7.0.8 (revid:[e-mail]-20090826132541-yablppc59e3yb54l) (version source revid:[e-mail]-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)

[26 Aug 2009 13:46] Bugs System

Pushed into 5.1.37-ndb-6.3.27 (revid:[e-mail]-20090826105955-bkj027t47gfbamnc) (version source revid:[e-mail]-20090826105955-bkj027t47gfbamnc) (merge vers: 5.1.37-ndb-6.3.27) (pib:11)

[26 Aug 2009 13:48] Bugs System

Pushed into 5.1.37-ndb-6.2.19 (revid:[e-mail]-20090825194404-37rtosk049t9koc4) (version source revid:[e-mail]-20090825194404-37rtosk049t9koc4) (merge vers: 5.1.37-ndb-6.2.19) (pib:11)

[27 Aug 2009 16:33] Bugs System

Pushed into 5.1.35-ndb-7.1.0 (revid:[e-mail]-20090827163030-6o3kk6r2oua159hr) (version source revid:[e-mail]-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)

[7 Oct 2009 20:24] Paul DuBois

The 5.4 fix has been pushed to 5.4.2.