| Bug #43414 | Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 | ||
|---|---|---|---|
| Submitted: | 5 Mar 2009 14:20 | Modified: | 18 Jun 2010 1:15 |
| Reporter: | Georgi Kodinov | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Compiling | Severity: | S2 (Serious) |
| Version: | 5.0-bzr, 5.1-bzr, 6.0-bzr | OS: | Linux (Fedora 10 64 bit) |
| Assigned to: | Staale Smedseng | CPU Architecture: | Any |
[5 Mar 2009 14:25]
Georgi Kodinov
compilation output
Attachment: comp.out.gz (application/x-gzip, text), 120.93 KiB.
[5 Mar 2009 20:29]
Sveta Smirnova
Thank you for the report. Verified as described.
[9 Jun 2009 12:56]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/75901 2768 Staale Smedseng 2009-06-09 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 Compiling MySQL with gcc 4.3.2 and later produces a number of warnings, many of which are new with the recent compiler versions. This bug will be resolved in more than one patch to limit the size of changesets. This is the first patch, fixing a number of the warnings, predominantly "suggest using parentheses around && in ||", and empty for and while bodies.
[9 Jun 2009 16:11]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/75933 2768 Staale Smedseng 2009-06-09 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 Compiling MySQL with gcc 4.3.2 and later produces a number of warnings, many of which are new with the recent compiler versions. This bug will be resolved in more than one patch to limit the size of changesets. This is the first patch, fixing a number of the warnings, predominantly "suggest using parentheses around && in ||", and empty for and while bodies.
[10 Jun 2009 14:04]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/76028 2769 Staale Smedseng 2009-06-10 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 Compiling MySQL with gcc 4.3.2 and later produces a number of warnings, many of which are new with the recent compiler versions. This bug will be resolved in more than one patch to limit the size of changesets. This is the second patch, fixing more of the warnings.
[16 Jun 2009 8:33]
Bugs System
Pushed into 5.0.84 (revid:gkodinov@mysql.com-20090616082753-kwe0l8uoictxhojf) (version source revid:staale.smedseng@sun.com-20090609161121-rdk1g1rv1myp92de) (merge vers: 5.0.83) (pib:6)
[16 Jun 2009 11:05]
Bugs System
Pushed into 5.1.36 (revid:joro@sun.com-20090616102155-3zhezogudt4uxdyn) (version source revid:matthias.leich@sun.com-20090609190531-i6yr10m1s33dlvri) (merge vers: 5.1.36) (pib:6)
[17 Jun 2009 14:52]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/76471 2776 Staale Smedseng 2009-06-17 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 Compiling MySQL with gcc 4.3.2 and later produces a number of warnings, many of which are new with the recent compiler versions. This bug will be resolved in more than one patch to limit the size of changesets. This is the second patch, fixing more of the warnings.
[17 Jun 2009 19:28]
Bugs System
Pushed into 5.4.4-alpha (revid:alik@sun.com-20090616183122-chjzbaa30qopdra9) (version source revid:matthias.leich@sun.com-20090609174954-3ao9iz97nzrfg9yl) (merge vers: 5.4.4-alpha) (pib:11)
[24 Jun 2009 14:13]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/77045 2784 Staale Smedseng 2009-06-24 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 Compiling MySQL with gcc 4.3.2 and later produces a number of warnings, many of which are new with the recent compiler versions. This is the third changeset for this bug.
[24 Jun 2009 15:37]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/77053 2784 Staale Smedseng 2009-06-24 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 Compiling MySQL with gcc 4.3.2 and later produces a number of warnings, many of which are new with the recent compiler versions. This is the third changeset for this bug.
[7 Jul 2009 7:52]
Bugs System
Pushed into 5.0.84 (revid:joro@sun.com-20090707074938-ksah1ibn0vs92cem) (version source revid:alexey.kopytov@sun.com-20090617170039-hg1q3oyr25n31995) (merge vers: 5.0.84) (pib:11)
[8 Jul 2009 13:30]
Bugs System
Pushed into 5.1.37 (revid:joro@sun.com-20090708131116-kyz8iotbum8w9yic) (version source revid:alexey.kopytov@sun.com-20090617165846-y4irgnnucmedgzg8) (merge vers: 5.1.36) (pib:11)
[9 Jul 2009 7:35]
Bugs System
Pushed into 5.0.84 (revid:joro@sun.com-20090707074938-ksah1ibn0vs92cem) (version source revid:alexey.kopytov@sun.com-20090617170039-hg1q3oyr25n31995) (merge vers: 5.0.84) (pib:11)
[9 Jul 2009 7:38]
Bugs System
Pushed into 5.1.37 (revid:joro@sun.com-20090708131116-kyz8iotbum8w9yic) (version source revid:alexey.kopytov@sun.com-20090617165846-y4irgnnucmedgzg8) (merge vers: 5.1.36) (pib:11)
[10 Jul 2009 11:21]
Bugs System
Pushed into 5.4.4-alpha (revid:anozdrin@bk-internal.mysql.com-20090710111017-bnh2cau84ug1hvei) (version source revid:kristofer.pettersson@sun.com-20090617180427-zxqutdhvhzdhoa8s) (merge vers: 5.4.4-alpha) (pib:11)
[14 Jul 2009 17:28]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/78677 2800 Staale Smedseng 2009-07-14 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 This is the fourth changeset for this bug.
[13 Aug 2009 11:25]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/80753 2788 Staale Smedseng 2009-08-13 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 This patch fixes a number of GCC warnings about variables used before initialized. A new macro UNINIT_VAR() is introduced for use in the variable declaration, and LINT_INIT() usage will be gradually deprecated. (A workaround is used for g++, pending a patch for a g++ bug.) GCC warnings for unused results (attribute warn_unused_result) for a number of system calls (present at least in later Ubuntus) are also fixed.
[26 Aug 2009 13:46]
Bugs System
Pushed into 5.1.37-ndb-7.0.8 (revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (version source revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)
[26 Aug 2009 13:46]
Bugs System
Pushed into 5.1.37-ndb-6.3.27 (revid:jonas@mysql.com-20090826105955-bkj027t47gfbamnc) (version source revid:jonas@mysql.com-20090826105955-bkj027t47gfbamnc) (merge vers: 5.1.37-ndb-6.3.27) (pib:11)
[26 Aug 2009 13:48]
Bugs System
Pushed into 5.1.37-ndb-6.2.19 (revid:jonas@mysql.com-20090825194404-37rtosk049t9koc4) (version source revid:jonas@mysql.com-20090825194404-37rtosk049t9koc4) (merge vers: 5.1.37-ndb-6.2.19) (pib:11)
[27 Aug 2009 16:33]
Bugs System
Pushed into 5.1.35-ndb-7.1.0 (revid:magnus.blaudd@sun.com-20090827163030-6o3kk6r2oua159hr) (version source revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)
[28 Aug 2009 15:52]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/81889 2798 Staale Smedseng 2009-08-28 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 This patch fixes a number of GCC warnings about variables used before initialized. A new macro UNINIT_VAR() is introduced for use in the variable declaration, and LINT_INIT() usage will be gradually deprecated. (A workaround is used for g++, pending a patch for a g++ bug.) GCC warnings for unused results (attribute warn_unused_result) for a number of system calls (present at least in later Ubuntus, where the usual void cast trick doesn't work) are also fixed. @ client/mysqlmanager-pwgen.c A fix for warn_unused_result, adding fallback to use of srand()/rand() if /dev/random cannot be used. Also actually adds calls to rand() in the second branch so that it actually creates a random password.
[2 Sep 2009 10:26]
Bugs System
Pushed into 5.0.86 (revid:joro@sun.com-20090902102337-n5rw8227wwp5cpx8) (version source revid:staale.smedseng@sun.com-20090828155131-i5jj6kc9ejd8nam0) (merge vers: 5.0.86) (pib:11)
[2 Sep 2009 16:43]
Bugs System
Pushed into 5.1.39 (revid:joro@sun.com-20090902154533-8actmfcsjfqovgsb) (version source revid:staale.smedseng@sun.com-20090828162154-t70a4c1dgta7aiza) (merge vers: 5.1.39) (pib:11)
[14 Sep 2009 16:06]
Bugs System
Pushed into 5.4.4-alpha (revid:alik@sun.com-20090914155317-m1g9wodmndzdj4l1) (version source revid:alik@sun.com-20090914155317-m1g9wodmndzdj4l1) (merge vers: 5.4.4-alpha) (pib:11)
[16 Sep 2009 16:01]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/83506 2811 Staale Smedseng 2009-09-16 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 This patch cleans up the final warnings in 5.0 (excluding warnings in Innobase and NDB subtrees).
[17 Sep 2009 15:10]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/83621 2811 Staale Smedseng 2009-09-17 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 This is the fifth patch cleaning up more GCC warnings about variables used before initialized using the new macro UNINIT_VAR().
[22 Sep 2009 14:25]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/84137 3115 Staale Smedseng 2009-09-22 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 Cleaning up warnings not present in 5.0.
[23 Sep 2009 13:22]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/84369 3119 Staale Smedseng 2009-09-23 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 Cleaning up warnings not present in 5.0.
[23 Sep 2009 13:54]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/84388 3126 Staale Smedseng 2009-09-23 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 Cleaning up warnings not present in 5.0.
[30 Sep 2009 8:19]
Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20090929093622-1mooerbh12e97zux) (version source revid:staale.smedseng@sun.com-20090917155346-hqxi7vbz5s363uix) (merge vers: 5.4.4-alpha) (pib:11)
[30 Sep 2009 17:54]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/85255 3614 Staale Smedseng 2009-09-30 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 This is the sixth patch cleaning up more GCC warnings in mysql-pe. @ mysys/my_handler.c Wrong argument to my_error_register() after parameter change. Used in extra/perror application. @ sql-common/client.c Would print uninitialized error number if socket() succeeded while my_connect() failed on first iteration of the loop. @ unittest/backup/bstr_data_chunks-t.c Could possibly free memory not allocated and close non-open stream.
[1 Oct 2009 5:59]
Bugs System
Pushed into 5.1.39-ndb-6.3.28 (revid:jonas@mysql.com-20091001055605-ap2kiaarr7p40mmv) (version source revid:jonas@mysql.com-20091001055605-ap2kiaarr7p40mmv) (merge vers: 5.1.39-ndb-6.3.28) (pib:11)
[1 Oct 2009 7:25]
Bugs System
Pushed into 5.1.39-ndb-7.0.9 (revid:jonas@mysql.com-20091001072547-kv17uu06hfjhgjay) (version source revid:jonas@mysql.com-20091001071652-irejtnumzbpsbgk2) (merge vers: 5.1.39-ndb-7.0.9) (pib:11)
[1 Oct 2009 13:25]
Bugs System
Pushed into 5.1.39-ndb-7.1.0 (revid:jonas@mysql.com-20091001123013-g9ob2tsyctpw6zs0) (version source revid:jonas@mysql.com-20091001123013-g9ob2tsyctpw6zs0) (merge vers: 5.1.39-ndb-7.1.0) (pib:11)
[2 Oct 2009 9:34]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/85490 3617 Staale Smedseng 2009-10-02 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2. @ mysys/my_handler.c Wrong argument to my_error_register() after parameter change. Used in extra/perror application. @ unittest/backup/bstr_data_chunks-t.c Could possibly free memory not allocated and close non-open stream.
[5 Oct 2009 10:50]
Bugs System
Pushed into 5.1.39-ndb-6.2.19 (revid:jonas@mysql.com-20091005103850-dwij2dojwpvf5hi6) (version source revid:jonas@mysql.com-20090930185117-bhud4ek1y0hsj1nv) (merge vers: 5.1.39-ndb-6.2.19) (pib:11)
[6 Oct 2009 8:57]
Bugs System
Pushed into 5.0.87 (revid:joro@sun.com-20091006073202-rj21ggvo2gw032ks) (version source revid:kristofer.pettersson@sun.com-20090929151855-gvpblm4dnnubypdv) (merge vers: 5.0.87) (pib:11)
[6 Oct 2009 9:01]
Bugs System
Pushed into 5.1.40 (revid:joro@sun.com-20091006073316-lea2cpijh9r6on7c) (version source revid:staale.smedseng@sun.com-20090923132129-v7ckw3bio863hmz9) (merge vers: 5.1.40) (pib:11)
[22 Oct 2009 6:37]
Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20091022063126-l0qzirh9xyhp0bpc) (version source revid:alik@sun.com-20091019135554-s1pvptt6i750lfhv) (merge vers: 6.0.14-alpha) (pib:13)
[22 Oct 2009 7:09]
Bugs System
Pushed into 5.5.0-beta (revid:alik@sun.com-20091022060553-znkmxm0g0gm6ckvw) (version source revid:alik@sun.com-20091013094238-g67x6tgdm9a7uik0) (merge vers: 5.5.0-beta) (pib:13)
[18 Dec 2009 10:40]
Bugs System
Pushed into 5.1.41-ndb-7.1.0 (revid:jonas@mysql.com-20091218102229-64tk47xonu3dv6r6) (version source revid:jonas@mysql.com-20091218095730-26gwjidfsdw45dto) (merge vers: 5.1.41-ndb-7.1.0) (pib:15)
[18 Dec 2009 10:56]
Bugs System
Pushed into 5.1.41-ndb-6.2.19 (revid:jonas@mysql.com-20091218100224-vtzr0fahhsuhjsmt) (version source revid:jonas@mysql.com-20091217101452-qwzyaig50w74xmye) (merge vers: 5.1.41-ndb-6.2.19) (pib:15)
[18 Dec 2009 11:11]
Bugs System
Pushed into 5.1.41-ndb-6.3.31 (revid:jonas@mysql.com-20091218100616-75d9tek96o6ob6k0) (version source revid:jonas@mysql.com-20091217154335-290no45qdins5bwo) (merge vers: 5.1.41-ndb-6.3.31) (pib:15)
[18 Dec 2009 11:25]
Bugs System
Pushed into 5.1.41-ndb-7.0.11 (revid:jonas@mysql.com-20091218101303-ga32mrnr15jsa606) (version source revid:jonas@mysql.com-20091218064304-ezreonykd9f4kelk) (merge vers: 5.1.41-ndb-7.0.11) (pib:15)
[6 Jan 2010 15:11]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/96136 3034 Ingo Struewing 2010-01-06 WL#5101 - MySQL Backup back port Merged revid:staale.smedseng@sun.com-20091002093337-8nkzufcvfxnrlrw5 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2. original changeset: 3590.5.3 @ cmd-line-utils/readline/rlmbutil.h WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL @ mysys/lf_alloc-pin.c WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL @ mysys/my_handler.c WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL Wrong argument to my_error_register() after parameter change. Used in extra/perror application. @ sql/ha_partition.cc WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL @ sql/handler.cc WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL @ sql/item_sum.cc WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL @ sql/sql_base.cc WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL @ sql/sql_plugin.cc WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL @ sql/sql_plugin_services.h WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL @ sql/sql_repl.cc WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL @ storage/myisam/mi_create.c WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL @ storage/myisam/mi_log.c WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL @ strings/my_vsnprintf.c WL#5101 - MySQL Backup back port Bug #43414 Parenthesis (and other) warnings compiling MySQL
[19 Feb 2010 17:50]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/100906 3914 Staale Smedseng 2010-02-19 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 This is the final patch in the context of this bug. This patch will also be pushed to 5.1-bugteam (a subset of this patch).
[22 Feb 2010 13:24]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/101066 3348 Staale Smedseng 2010-02-22 Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 This is the final patch in the context of this bug. @ cmd-line-utils/readline/rlmbutil.h Changed in a previous patch, reverted by a backport. @ cmd-line-utils/readline/text.c Static var initialization. @ extra/yassl/include/yassl_error.hpp SetErrorString handles errors outside of the YasslError enum. @ extra/yassl/src/ssl.cpp SetErrorString handles errors outside of the YasslError enum. @ extra/yassl/src/yassl_error.cpp SetErrorString handles errors outside of the YasslError enum.
[1 Mar 2010 8:48]
Bugs System
Pushed into 5.1.45 (revid:joro@sun.com-20100301083827-xnimmrjg6bh33o1o) (version source revid:azundris@mysql.com-20100222175719-viuh0f3gdsrkgv0r) (merge vers: 5.1.45) (pib:16)
[1 Mar 2010 14:29]
MC Brown
No changelog entry required.
[2 Mar 2010 14:37]
Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20100302142746-u1gxdf5yk2bjrq3e) (version source revid:alik@sun.com-20100225090938-2j5ybqoau570mytu) (merge vers: 6.0.14-alpha) (pib:16)
[2 Mar 2010 14:42]
Bugs System
Pushed into 5.5.3-m2 (revid:alik@sun.com-20100302072233-t3uqgjzdukt1pyhe) (version source revid:alexey.kopytov@sun.com-20100223132645-fj9ybhpzs9fl1voe) (merge vers: 5.5.2-m2) (pib:16)
[2 Mar 2010 14:47]
Bugs System
Pushed into mysql-next-mr (revid:alik@sun.com-20100302072432-k8xvfkgcggkwgi94) (version source revid:alik@sun.com-20100224135227-rcqs9pe9b2in80pf) (pib:16)
[2 Mar 2010 14:56]
MC Brown
No changelog entry needed.
[17 Jun 2010 12:02]
Bugs System
Pushed into 5.1.47-ndb-7.0.16 (revid:martin.skold@mysql.com-20100617114014-bva0dy24yyd67697) (version source revid:vasil.dimov@oracle.com-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)
[17 Jun 2010 12:43]
Bugs System
Pushed into 5.1.47-ndb-6.2.19 (revid:martin.skold@mysql.com-20100617115448-idrbic6gbki37h1c) (version source revid:martin.skold@mysql.com-20100609140708-52rvuyq4q500sxkq) (merge vers: 5.1.45-ndb-6.2.19) (pib:16)
[17 Jun 2010 13:29]
Bugs System
Pushed into 5.1.47-ndb-6.3.35 (revid:martin.skold@mysql.com-20100617114611-61aqbb52j752y116) (version source revid:vasil.dimov@oracle.com-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)
Description: A lot of compilation warnings with this GCC version. Make it easy to skip the "real" ones when writing code. Here's an example (the full log attached) : In file included from mysql_priv.h:573, from sql_lex.cc:21: table.h: In member function ‘bool TABLE_LIST::placeholder()’: table.h:731: warning: suggest parentheses around && within || In file included from mysql_priv.h:575, from sql_lex.cc:21: field.h: In member function ‘virtual void Field::set_default()’: field.h:173: warning: suggest parentheses around arithmetic in operand of | In file included from item.h:2199, from mysql_priv.h:587, from sql_lex.cc:21: spatial.h: In member function ‘int MBR::touches(const MBR*)’: spatial.h:121: warning: suggest parentheses around && within || spatial.h:124: warning: suggest parentheses around && within || sql_lex.cc: In function ‘int MYSQLlex(void*, void*)’: sql_lex.cc:596: warning: array subscript has type ‘char’ sql_lex.cc:663: warning: suggest a space before ‘;’ or explicit braces around em pty body in ‘for’ statement sql_lex.cc:675: warning: suggest a space before ‘;’ or explicit braces around em pty body in ‘for’ statement sql_lex.cc:677: warning: array subscript has type ‘char’ sql_lex.cc:710: warning: array subscript has type ‘char’ sql_lex.cc:784: warning: suggest a space before ‘;’ or explicit braces around em pty body in ‘for’ statement sql_lex.cc:788: warning: array subscript has type ‘char’ sql_lex.cc:874: warning: suggest a space before ‘;’ or explicit braces around em pty body in ‘while’ statement sql_lex.cc:885: warning: array subscript has type ‘char’ sql_lex.cc:886: warning: array subscript has type ‘char’ sql_lex.cc:897: warning: array subscript has type ‘char’ sql_lex.cc:898: warning: array subscript has type ‘char’ sql_lex.cc:901: warning: array subscript has type ‘char’ sql_lex.cc:1045: warning: array subscript has type ‘char’ sql_lex.cc:1070: warning: array subscript has type ‘char’ sql_lex.cc:1082: warning: suggest a space before ‘;’ or explicit braces around e mpty body in ‘for’ statement sql_lex.cc: In member function ‘void st_select_lex::print_limit(THD*, String*)’: sql_lex.cc:1671: warning: suggest parentheses around && within || How to repeat: Compile a server with BUILD/compile-pentium-debug-max Suggested fix: Resolve the warnings