Bug #43114 wait_until_count_sessions too restrictive, random PB failures
Submitted: 23 Feb 2009 16:03 Modified: 18 Mar 2009 14:43
Reporter: Matthias Leich Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Tests Severity:S3 (Non-critical)
Version:5.0,5.1,6.0 OS:Any
Assigned to: Matthias Leich CPU Architecture:Any
Tags: pushbuild, random failure

[23 Feb 2009 16:03] Matthias Leich
Description:
As long as not all tests are cleaned up around
use of multiple sessions, the following could
happen:
./mtr A B
A works with several sessions
  Even if there is a disconnect for all sessions
  <> "default" within the test, it could happen
  that the disconnect is not finished before the
  execution of the next test starts.
B has the usual "count_sessions" at test begin
  and "wait_until_count_sessions" at test end.
  Nice case:
    All sessions of test A are really disconnected
    when the execution of test B starts
    "count_sessions" calculates 1 session
    "wait_until_count_sessions" waits till we reached
    one open session.
  Bad case:
    Not all sessions of test A are really disconnected
    So "count_sessions" calculates maybe 2 sessions.
    During the test execution the session belonging to A
    and also the sessions created by test B get disconnected
    like expected.
    This means "wait_until_count_sessions" waits that we
    reach two open sessions again whereas we are already
    down to 1.

Pushbuild on 6.0-bugteam:
CURRENT_TEST: main.sp-threads
--- .../mysql-test/r/sp-threads.result
+++ .../mysql-test/r/sp-threads.reject 
@@ -89,3 +89,8 @@
 drop procedure p1;
 drop procedure p2;
 drop table t1;
+# Timeout in wait_until_count_sessions.inc
+# Number of sessions   expected: 2   found: 1
+SHOW PROCESSLIST;
+Id    User    Host    db    Command    Time    State    Info
+387    root    localhost    test    Query    0    NULL    SHOW PROCESSLIST The test will fail with

How to repeat:
See above

Suggested fix:
Please modify wait_until_count_sessions.inc .
The condition should be
SELECT $current_sessions <= $count_sessions
[3 Mar 2009 20:54] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/68144
[5 Mar 2009 13:35] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/68384
[6 Mar 2009 14:56] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/68509
[6 Mar 2009 20:33] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/68557
[10 Mar 2009 17:40] Matthias Leich
Pushed to
mysql-6.0-bugteam
mysql-5.1-bugteam
mysql-5.0-bugteam
[13 Mar 2009 19:04] Bugs System
Pushed into 5.1.33 (revid:joro@sun.com-20090313111355-7bsi1hgkvrg8pdds) (version source revid:zhou.li@sun.com-20090311061050-ihp0g77znonq1tuq) (merge vers: 5.1.33) (pib:6)
[13 Mar 2009 19:10] Bugs System
Pushed into 5.0.80 (revid:chad@mysql.com-20090312173213-viivy35mb79n1zlg) (version source revid:chad@mysql.com-20090312173213-viivy35mb79n1zlg) (merge vers: 5.0.80) (pib:6)
[14 Mar 2009 23:51] Paul DuBois
Test case changes. No changelog entry needed.

Setting report to NDI pending push into 6.0.x.
[18 Mar 2009 13:18] Bugs System
Pushed into 6.0.11-alpha (revid:joro@sun.com-20090318122208-1b5kvg6zeb4hxwp9) (version source revid:matthias.leich@sun.com-20090306203352-rf8dh80l21cls5t2) (merge vers: 6.0.10-alpha) (pib:6)
[18 Mar 2009 14:43] Paul DuBois
Test case changes. No changelog entry needed.
[9 May 2009 16:42] Bugs System
Pushed into 5.1.34-ndb-6.2.18 (revid:jonas@mysql.com-20090508185236-p9b3as7qyauybefl) (version source revid:jonas@mysql.com-20090508100057-30ote4xggi4nq14v) (merge vers: 5.1.33-ndb-6.2.18) (pib:6)
[9 May 2009 17:39] Bugs System
Pushed into 5.1.34-ndb-6.3.25 (revid:jonas@mysql.com-20090509063138-1u3q3v09wnn2txyt) (version source revid:jonas@mysql.com-20090508175813-s6yele2z3oh6o99z) (merge vers: 5.1.33-ndb-6.3.25) (pib:6)
[9 May 2009 18:37] Bugs System
Pushed into 5.1.34-ndb-7.0.6 (revid:jonas@mysql.com-20090509154927-im9a7g846c6u1hzc) (version source revid:jonas@mysql.com-20090509073226-09bljakh9eppogec) (merge vers: 5.1.33-ndb-7.0.6) (pib:6)