Bug #42928 binlog-format setting prevents server from start if binary logging is disabled

Description:
If one sets binlog-format but does NOT enable binary log, server does not start. The following messages appears in the error log:

090217 12:47:14 [ERROR] You need to use --log-bin to make --binlog-format work.
090217 12:47:14 [ERROR] Aborting

090217 12:47:14 [Note] C:\Program Files\MySQL\MySQL Server 5.1\bin\mysqld: Shutdown complete

This happens even on read-only slave. Some users may think that they should set binlog-format on slave to the same value as on master, and if they do not have binary logging eneble their slave will refuse to start.

How to repeat:
Add --binlog-format=MIXED to mysqld options or my.cnf/my.ini and try to start the server.

Suggested fix:
Ignore this setting if binary log is enabled and write a warning to the error log about it. Do NOT prevent server start.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/73294

2849 Luis Soares	2009-05-04
      BUG#42928: binlog-format setting prevents server from start if binary
      logging is disabled
      
      If one sets binlog-format but does NOT enable binary log, server
      refuses to start up. The following messages appears in the error log:
      
      090217 12:47:14 [ERROR] You need to use --log-bin to make
      --binlog-format work.  
      090217 12:47:14 [ERROR] Aborting
      
      This patch addresses this by making the server not to bail out if the
      binlog-format is set without the log-bin option. Additionally, the
      specified binlog-format is stored, in the global system variable
      "binlog_format", and a warning is printed instead of an error.

Pushed to 6.0-rpl.

Pushed into 5.4.4-alpha (revid:zhenxing.he@sun.com-20090612081554-kmu72j3wenjn82a8) (version source revid:zhenxing.he@sun.com-20090612034751-dqd4y0bv0iln1yaj) (merge vers: 5.4.4-alpha) (pib:7)

Pushed into 5.4.4-alpha (revid:alik@sun.com-20090616183122-chjzbaa30qopdra9) (version source revid:zhenxing.he@sun.com-20090612034751-dqd4y0bv0iln1yaj) (merge vers: 5.4.4-alpha) (pib:11)

Documented bugfix in the 5.4.4 changelog as follows:

      When the logging format was set without binary logging being enabled,
      the server failed to start. Now, the server starts, binlog_format is set,
      and a warning is logged instead of an error.

Also noted behaviour change in 5.4 Manual, old behaviour as known issue in 5.1/6.0 versions.

Noted in 5.4.2 changelog because next 5.4 version will be 5.4.2 and not 5.4.4.

Ignore previous comment about 5.4.2.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/85011

3113 Luis Soares	2009-09-29
      BUG#42928: binlog-format setting prevents server from start if binary
      logging is disabled
      
      NOTE: this is the backport to next-mr.
            
      If one sets binlog-format but does NOT enable binary log, server
      refuses to start up. The following messages appears in the error log:
            
      090217 12:47:14 [ERROR] You need to use --log-bin to make
      --binlog-format work.  
      090217 12:47:14 [ERROR] Aborting
            
      This patch addresses this by making the server not to bail out if the
      binlog-format is set without the log-bin option. Additionally, the
      specified binlog-format is stored, in the global system variable
      "binlog_format", and a warning is printed instead of an error.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/85031

3118 Luis Soares	2009-09-29
      BUG#42928: binlog-format setting prevents server from start if binary
      logging is disabled
            
      NOTE: this is the backport to next-mr.
                  
      If one sets binlog-format but does NOT enable binary log, server
      refuses to start up. The following messages appears in the error log:
                  
      090217 12:47:14 [ERROR] You need to use --log-bin to make
      --binlog-format work.  
      090217 12:47:14 [ERROR] Aborting
                  
      This patch addresses this by making the server not to bail out if the
      binlog-format is set without the log-bin option. Additionally, the
      specified binlog-format is stored, in the global system variable
      "binlog_format", and a warning is printed instead of an error.

Pushed into 6.0.14-alpha (revid:alik@sun.com-20091027094604-9p7kplu1vd2cvcju) (version source revid:zhenxing.he@sun.com-20091026140226-uhnqejkyqx1aeilc) (merge vers: 6.0.14-alpha) (pib:13)

Now documented for 6.0.14; closed.

Pushed into 5.5.0-beta (revid:alik@sun.com-20091110093229-0bh5hix780cyeicl) (version source revid:alik@sun.com-20091027095744-rf45u3x3q5d1f5y0) (merge vers: 5.5.0-beta) (pib:13)

Also documented in the 5.5.0 changelog; closed.