Bug #41893 main.variables mysql-test fails if new variable like '%alloc%' is added
Submitted: 6 Jan 2009 7:42 Modified: 18 Mar 2009 14:38
Reporter: Vasil Dimov Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Tests Severity:S3 (Non-critical)
Version:5.1-r2705 OS:Any
Assigned to: Patrick Crews CPU Architecture:Any

[6 Jan 2009 7:42] Vasil Dimov 
Description:
The main.variables mysql-test executes the statement:

show variables like '%alloc%';

and expects that the output will be:

+------------------------------+-------+
| Variable_name                | Value |
+------------------------------+-------+
| query_alloc_block_size       | 8192  | 
| query_prealloc_size          | 8192  | 
| range_alloc_block_size       | 4096  | 
| transaction_alloc_block_size | 8192  | 
| transaction_prealloc_size    | 4096  | 
+------------------------------+-------+

but this breaks if new variable that matches '%alloc%' is added.

How to repeat:
Add a new variable that matches '%alloc%'.

Suggested fix:
Explicitly list the full names of all variables of interest instead of relying on matching patterns that will potentially match more than expected.
[6 Jan 2009 7:44] Vasil Dimov 
Patch to fix this bug

Attachment: bug41893.diff (application/octet-stream, text), 0 bytes.
[6 Jan 2009 7:46] Vasil Dimov 
Patch to fix this bug (sorry, the previous one is empty)

Attachment: bug41893.diff (application/octet-stream, text), 5.14 KiB.
[24 Feb 2009 16:24] Patrick Crews 
At first I thought this was not a bug, but given the scope of the test, the suggested change is correct.

Will be using this patch + cleaning up the test.

Thank you for the bug report.  Expect a change shortly.
[26 Feb 2009 8:58] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/67647

2760 Patrick Crews	2009-02-26
      Bug#41893: main.variables mysql-test fails if new variable like '%alloc%' is added.
      
      Started fix in 5.0 as the same issue is here.
      Revising queries used given what appears to be the scope of this test to only select the manipulated variables.
      Added tests for values that are / are not multiples of 1024 to test rounding / constraints.
      This behavior is not currently documented (docs bug has been opened)
[26 Feb 2009 9:38] Bernt Marius Johnsen 
Ok to push.
[26 Feb 2009 16:01] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/67698

2761 Patrick Crews	2009-02-26
      Bug#41893 - main.variables mysql-test fails if new variable like '%alloc%' is added.
      
      Fixed a typo in the bug fix patch.
[27 Feb 2009 8:25] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/67795

2824 Patrick Crews	2009-02-27
      Bug#41893: main.variables mysql-test fails in new variable like '%alloc%' is added.
      
      Added ORDER BY clause to I_S query to ensure consistent order.
      There were differences between 5.1 and 6.0 output.  Correcting it 5.1.
[27 Feb 2009 13:01] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/67845

2763 Patrick Crews	2009-02-27
      Bug#41893:  Removal of trailing space noise causing Pushbuild failure.
[9 Mar 2009 14:12] Bugs System 
Pushed into 5.0.79 (revid:joro@sun.com-20090309135922-a0di9ebkxoj4d4wv) (version source revid:staale.smedseng@sun.com-20090227160758-td4jot2la75f9zy1) (merge vers: 5.0.79) (pib:6)
[13 Mar 2009 17:03] Paul DuBois 
Test case changes. No changelog entry needed.

Setting report to NDI pending push into 5.1.x/6.0.x.
[13 Mar 2009 19:02] Bugs System 
Pushed into 5.1.33 (revid:joro@sun.com-20090313111355-7bsi1hgkvrg8pdds) (version source revid:staale.smedseng@sun.com-20090227160332-3k1kc0rao6y07cbp) (merge vers: 5.1.33) (pib:6)
[13 Mar 2009 20:25] Paul DuBois 
Test case changes. No changelog entry needed.

Setting report to NDI pending push into 6.0.x.
[18 Mar 2009 13:18] Bugs System 
Pushed into 6.0.11-alpha (revid:joro@sun.com-20090318122208-1b5kvg6zeb4hxwp9) (version source revid:staale.smedseng@sun.com-20090227155937-ly92xe32djh3o6xo) (merge vers: 6.0.10-alpha) (pib:6)
[18 Mar 2009 14:38] Paul DuBois 
Test case changes. No changelog entry needed.
[9 May 2009 16:39] Bugs System 
Pushed into 5.1.34-ndb-6.2.18 (revid:jonas@mysql.com-20090508185236-p9b3as7qyauybefl) (version source revid:jonas@mysql.com-20090508100057-30ote4xggi4nq14v) (merge vers: 5.1.33-ndb-6.2.18) (pib:6)
[9 May 2009 17:37] Bugs System 
Pushed into 5.1.34-ndb-6.3.25 (revid:jonas@mysql.com-20090509063138-1u3q3v09wnn2txyt) (version source revid:jonas@mysql.com-20090508175813-s6yele2z3oh6o99z) (merge vers: 5.1.33-ndb-6.3.25) (pib:6)
[9 May 2009 18:34] Bugs System 
Pushed into 5.1.34-ndb-7.0.6 (revid:jonas@mysql.com-20090509154927-im9a7g846c6u1hzc) (version source revid:jonas@mysql.com-20090509073226-09bljakh9eppogec) (merge vers: 5.1.33-ndb-7.0.6) (pib:6)