Bug #38303 mysqldump: Needs LOCAL for FLUSH TABLES when --dump-slave is enabled
Submitted: 23 Jul 3:01 Modified: 23 Jul 5:43
Reporter: Paul DuBois
Status: Patch pending
Category:Client Severity:S3 (Non-critical)
Version:6.0 OS:Any
Assigned to: Chad MILLER Target Version:6.0+
Triage: Triaged: D3 (Medium)

[23 Jul 3:01] Paul DuBois 
Description:
This is a followup to Bug#35157, which adds LOCAL to FLUSH TABLES when --master-data is
enabled.

The problem is that LOCAL should also be added when --dump-slave is enabled, and it is
not.

How to repeat:
Execute mysqldump --dump-slave db_name and examine the server's query log. A FLUSH TABLES
statement will be there, but it should be FLUSH /*!40101 LOCAL */ TABLES, the same as when
--master-data is used.

Suggested fix:
The following bit of code needs to also test opt_slave_data, not just opt_master_data:

  return
    ( mysql_query_with_error_report(mysql_con, 0,
                                    ((opt_master_data != 0) ?
                                        "FLUSH /*!40101 LOCAL */ TABLES" :
                                        "FLUSH TABLES")) ||
      mysql_query_with_error_report(mysql_con, 0,
                                    "FLUSH TABLES WITH READ LOCK") );
[23 Jul 3:02] Paul DuBois 
Fix synopsis, assign to Chad.
[23 Jul 5:43] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/50248

2680 Chad MILLER	2008-07-22
      Bug#38303: mysqldump: Needs LOCAL for FLUSH TABLES when --dump-slave is enabled
      
      Add additional case of dump-slave (opt_slave_data) to "LOCAL" condition for
      FLUSH TABLES.