Bug #37098 Get rid of "Installed (but unpackaged)" files in the RPM build
Submitted: 30 May 2008 12:37 Modified: 13 Jan 2009 1:47
Reporter: Joerg Bruehe Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Packaging Severity:S3 (Non-critical)
Version:4,1, 5.0, 5.1, 6.0, 6.2 OS:Linux (RPM only)
Assigned to: Joerg Bruehe CPU Architecture:Any

[30 May 2008 12:37] Joerg Bruehe
Description:
The issue is an old one ...

Warnings in the 5.0.62 RPM build logs about unpackaged files:

    - cluster:
warning: Installed (but unpackaged) file(s) found:
   /usr/bin/innochecksum
   /usr/share/man/man1/make_win_bin_dist.1.gz
   /usr/share/man/man1/make_win_src_distribution.1.gz
   /usr/share/man/man1/mysql_find_rows.1.gz
   /usr/share/man/man1/mysqlbug.1.gz
   /usr/share/man/man1/mysqlmanager-pwgen.1.gz
   /usr/share/man/man1/mysqlmanagerc.1.gz
   /usr/share/man/man1/ndb_print_backup_file.1.gz
   /usr/share/man/man1/ndb_print_schema_file.1.gz
   /usr/share/man/man1/ndb_print_sys_file.1.gz

    - enterprise:
warning: Installed (but unpackaged) file(s) found:
   /usr/share/man/man1/make_win_bin_dist.1.gz
   /usr/share/man/man1/make_win_src_distribution.1.gz
   /usr/share/man/man1/mysql_find_rows.1.gz
   /usr/share/man/man1/mysqlbug.1.gz
   /usr/share/man/man1/mysqlmanager-pwgen.1.gz
   /usr/share/man/man1/mysqlmanagerc.1.gz

    - enterprise-gpl:
warning: Installed (but unpackaged) file(s) found:
   /usr/share/man/man1/make_win_bin_dist.1.gz
   /usr/share/man/man1/make_win_src_distribution.1.gz
   /usr/share/man/man1/mysql_find_rows.1.gz
   /usr/share/man/man1/mysqlbug.1.gz
   /usr/share/man/man1/mysqlmanager-pwgen.1.gz
   /usr/share/man/man1/mysqlmanagerc.1.gz

However, when fixing this, we should also check the last 4.1 RPM logs.

How to repeat:
Build RPMs ...

Suggested fix:
1) Add the 3 NDB manuals to the "cluster" RPM.
   Delete "innochecksum" in a "cluster" RPM build
   (why did it get built at all ?)

2) Forcefully delete the Windows-specific man pages in the RPM build.

3) Add man pages for "mysqlbug", "mysqlmanager-pwgen", and "mysqlmanagerc"
   to all RPMs that contain these binaries.
[18 Aug 2008 13:13] Joerg Bruehe
I checked the most recent RPM build logs from 4.1 up:

Sadly, in all versions we have such "unpackaged" files.

An exact list is more than fits into this report,
so a short classification must be enough:
- In 6.0, it is the "example" engine, some manual pages,
  the "sql-bench/" subdirectory, and some "Maria" files;
- in "Cluster 6.2", it is the "example" engine, some manual pages,
  the "sql-bench/" subdirectory, and some Cluster tools;
- in 5.1, it is the "example" engine, some manual pages,
  and the "sql-bench/" subdirectory;
- in 5.0, it is just some manual pages;
- in 4.1, it is several manual pages;
- across versions, the handling of "innochecksum" and "libmerge"
  seems inconsistent (not yet fully analyzed).

As regards bug importance:
An inconsistency between the items built and those packages needs to be checked, including files (be they tools or manual pages) is more than just a "feature request".
[19 Aug 2008 14:22] Joerg Bruehe
As 4.1 is in "extended maintenance" only, we will not change it
for those "unpackaged files" (the defect isn't severe enough).
For documentation, these are the ones reported in 4.1.24 RPMs:

Unpackaged manual pages in 4.1
   /usr/share/man/man1/make_win_src_distribution.1.gz
   /usr/share/man/man1/mysql-stress-test.pl.1.gz
   /usr/share/man/man1/mysql_client_test_embedded.1.gz
   /usr/share/man/man1/mysql_find_rows.1.gz
   /usr/share/man/man1/mysql_fix_extensions.1.gz
   /usr/share/man/man1/mysql_secure_installation.1.gz
   /usr/share/man/man1/mysql_tableinfo.1.gz
   /usr/share/man/man1/mysql_waitpid.1.gz
   /usr/share/man/man1/mysqlbug.1.gz
   /usr/share/man/man1/mysqlmanager-pwgen.1.gz
   /usr/share/man/man1/mysqlmanagerc.1.gz
   /usr/share/man/man1/mysqltest_embedded.1.gz
   /usr/share/man/man1/ndb_config.1.gz
   /usr/share/man/man1/ndb_cpcd.1.gz
   /usr/share/man/man1/ndb_delete_all.1.gz
   /usr/share/man/man1/ndb_desc.1.gz
   /usr/share/man/man1/ndb_drop_index.1.gz
   /usr/share/man/man1/ndb_drop_table.1.gz
   /usr/share/man/man1/ndb_error_reporter.1.gz
   /usr/share/man/man1/ndb_mgm.1.gz
   /usr/share/man/man1/ndb_print_backup_file.1.gz
   /usr/share/man/man1/ndb_print_schema_file.1.gz
   /usr/share/man/man1/ndb_print_sys_file.1.gz
   /usr/share/man/man1/ndb_restore.1.gz
   /usr/share/man/man1/ndb_select_all.1.gz
   /usr/share/man/man1/ndb_select_count.1.gz
   /usr/share/man/man1/ndb_show_tables.1.gz
   /usr/share/man/man1/ndb_size.pl.1.gz
   /usr/share/man/man1/ndb_waiter.1.gz
   /usr/share/man/man8/ndb_mgmd.8.gz
   /usr/share/man/man8/ndbd.8.gz
   /usr/share/man/man1/comp_err.1.gz
   /usr/share/man/man1/mysql_convert_table_format.1.gz
   /usr/share/man/man1/mysql_create_system_tables.1.gz
   /usr/share/man/man1/mysql_setpermission.1.gz
   /usr/share/man/man1/resolve_stack_dump.1.gz
   /usr/share/man/man1/resolveip.1.gz

Unpackaged binaries in 4.1
   /usr/bin/mysqlmanager
   /usr/bin/mysqlmanager-pwgen
   /usr/bin/mysqlmanagerc
   /usr/lib64/mysql/libmerge.a
   /usr/lib64/mysql/libndbclient.a
   /usr/lib64/mysql/libndbclient.la
   /usr/lib64/mysql/libndbclient.so.1.0.0
   /usr/sbin/ndb_cpcd

("lib64/" or "lib/" depending on the CPU)
[25 Aug 2008 19:08] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/52489

2652 Joerg Bruehe	2008-08-25
      Bug#37098  Get rid of "Installed (but unpackaged)" files in the RPM build
      
      Mostly, this affected files (programs, scripts, and manual pages)
      which got built during a RPM build but were not listed in the
      appropriate "%files" section of the "spec" file.
      This is fixed now, they are added.
      
      To make this consistent, this patch also makes the build of "innochecksum"
      (and its inclusion in a tar.gz or other package) depend on whether InnoDB
      is configured in the build.
      
      Also, some tools to create Windows packages are irrelevant in any binary
      Unix package (not the sources !), and so they are deleted before packaging.
[27 Aug 2008 14:05] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/52712

2682 Joerg Bruehe	2008-08-27 [merge]
      Bug#37098  Get rid of "Installed (but unpackaged)" files in the RPM build
      
      Merge it up from 5.0 to 5.1,
      adapt to some version differences.
[27 Aug 2008 15:04] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/52737

2772 Joerg Bruehe	2008-08-27 [merge]
      Bug#37098  Get rid of "Installed (but unpackaged)" files in the RPM build
      
      Merge the fix up into 6.0
[9 Oct 2008 18:20] Bugs System
Pushed into 5.1.30  (revid:joerg@mysql.com-20080827140339-sh1eegd68wm8dawv) (version source revid:kpettersson@mysql.com-20080915214458-ejxj7ltezohabr3z) (pib:4)
[17 Oct 2008 16:42] Bugs System
Pushed into 6.0.8-alpha  (revid:joerg@mysql.com-20080827150131-gmhmrjd24b84za53) (version source revid:kpettersson@mysql.com-20080915213305-1ljm3tx7tgsdrne9) (pib:5)
[28 Oct 2008 21:04] Bugs System
Pushed into 5.1.29-ndb-6.2.17  (revid:joerg@mysql.com-20080827140339-sh1eegd68wm8dawv) (version source revid:tomas.ulin@sun.com-20081028140209-u4emkk1xphi5tkfb) (pib:5)
[28 Oct 2008 22:23] Bugs System
Pushed into 5.1.29-ndb-6.3.19  (revid:joerg@mysql.com-20080827140339-sh1eegd68wm8dawv) (version source revid:tomas.ulin@sun.com-20081028194045-0353yg8cvd2c7dd1) (pib:5)
[1 Nov 2008 9:48] Bugs System
Pushed into 5.1.29-ndb-6.4.0  (revid:joerg@mysql.com-20080827140339-sh1eegd68wm8dawv) (version source revid:jonas@mysql.com-20081101082305-qx5a1bj0z7i8ueys) (pib:5)
[12 Jan 2009 14:45] Joerg Bruehe
Sorry about the delay ...

The fixes for all trees (5.0, 5.1, and 6.0) were done in August,
and they are pushed to all trees.
I don't know why the tools missed it.  :-(

I assume there is no need to document it, but set it to "documenting" anyway.

We should evaluate build logs whether any "unpackaged" file fell through the cracks.
[13 Jan 2009 1:47] Paul DuBois
Per Joerg, no changelog entry needed.
[20 Aug 2009 19:48] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/81211

2967 Joerg Bruehe	2009-08-20 [merge]
      Merge the correction to the bug#37098 fix from 5.0 to 5.1.
[20 Aug 2009 19:52] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/81212

2873 Joerg Bruehe	2009-08-20 [merge]
      Merge the correction to the bug#37098 fix from 5.1 to 5.4.
[20 Aug 2009 20:00] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/81215

2969 Joerg Bruehe	2009-08-20 [merge]
      automerge the correction for bug#37098 into 5.1-build
[20 Aug 2009 20:09] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/81223

2787 Joerg Bruehe	2009-08-20 [merge]
      Merge the correction for the bug#37098 fix into 5.0-build
[25 Aug 2009 9:23] Bugs System
Pushed into 5.1.39 (revid:jperkin@sun.com-20090824091334-6ktgrhq218vl7zq1) (version source revid:joerg@mysql.com-20090821095644-12woawc4d2d3u7k4) (merge vers: 5.1.39) (pib:11)
[25 Aug 2009 9:24] Bugs System
Pushed into 5.0.86 (revid:joerg@mysql.com-20090820200740-cffxigf492lgo4m2) (version source revid:joerg@mysql.com-20090820200740-cffxigf492lgo4m2) (merge vers: 5.0.86) (pib:11)
[14 Sep 2009 16:05] Bugs System
Pushed into 5.4.4-alpha (revid:alik@sun.com-20090914155317-m1g9wodmndzdj4l1) (version source revid:alik@sun.com-20090914155317-m1g9wodmndzdj4l1) (merge vers: 5.4.4-alpha) (pib:11)
[16 Sep 2009 6:45] Bugs System
Pushed into 5.4.4-alpha (revid:alik@sun.com-20090916063112-8hjmu6wkxfx5qxf4) (version source revid:alik@sun.com-20090916062454-qzqttcefueqgsfn3) (merge vers: 5.4.4-alpha) (pib:11)
[1 Oct 2009 5:59] Bugs System
Pushed into 5.1.39-ndb-6.3.28 (revid:jonas@mysql.com-20091001055605-ap2kiaarr7p40mmv) (version source revid:jonas@mysql.com-20091001055605-ap2kiaarr7p40mmv) (merge vers: 5.1.39-ndb-6.3.28) (pib:11)
[1 Oct 2009 7:25] Bugs System
Pushed into 5.1.39-ndb-7.0.9 (revid:jonas@mysql.com-20091001072547-kv17uu06hfjhgjay) (version source revid:jonas@mysql.com-20091001071652-irejtnumzbpsbgk2) (merge vers: 5.1.39-ndb-7.0.9) (pib:11)
[1 Oct 2009 13:25] Bugs System
Pushed into 5.1.39-ndb-7.1.0 (revid:jonas@mysql.com-20091001123013-g9ob2tsyctpw6zs0) (version source revid:jonas@mysql.com-20091001123013-g9ob2tsyctpw6zs0) (merge vers: 5.1.39-ndb-7.1.0) (pib:11)
[5 Oct 2009 10:50] Bugs System
Pushed into 5.1.39-ndb-6.2.19 (revid:jonas@mysql.com-20091005103850-dwij2dojwpvf5hi6) (version source revid:jonas@mysql.com-20090930185117-bhud4ek1y0hsj1nv) (merge vers: 5.1.39-ndb-6.2.19) (pib:11)