Bug #36293 SQLDriverConnect does not return SQL_NO_DATA on cancel

Description:
Per ODBC docs this method should return SQL_NO_DATA when the user cancels the dialog to connect.  MyODBC, however, returns SQL_ERROR.

The offending lines are these:

------ driver/connect.c lines 683-688 ----------

    if (!pFunc(hwnd, prompt_instr, fDriverCompletion,
               szConnStrOut, cbConnStrOutMax, pcbConnStrOut))
    {
      set_dbc_error(hdbc, "HY000", "User cancelled.", 0);
      rc= SQL_ERROR;
      goto error;
    }

-----------------------------------------

How to repeat:
Call SQLDriverConnect from an application, wait for it to bring up the MySQL connection dialog, and hit cancel.  The return code from the call is SQL_ERROR even though no error has been committed.

Suggested fix:
Just change the line to "rc = SQL_NO_DATA" to behave like all other ODBC drivers

Hi Michel and thanks for your report.

Verified as described by looking into latest sources:

http://msdn2.microsoft.com/en-us/library/ms715433(VS.85).aspx clearly states:
If the user cancels a dialog box presented by the Driver Manager or the driver, SQLDriverConnect returns SQL_NO_DATA.

Return correct value

Attachment: bug36293.diff (text/plain), 930 bytes.

approved

The fix for this bug has been committed, and will be included in 5.1.5.

An entry has been added to the 5.1.5 Changelog:

SQLDriverConnect does not return SQL_NO_DATA on cancel. The ODBC documentation specifies that this method should return SQL_NO_DATA when the user cancels the dialog to connect. The connector, however, returns SQL_ERROR.