MySQL Bugs: #36001: Partitions: spelling and using some error messages

Bug #36001	Partitions: spelling and using some error messages
Submitted:	11 Apr 2008 17:13	Modified:	15 Mar 2009 8:34
Reporter:	Peter Gulutzan	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Partitions	Severity:	S3 (Non-critical)
Version:	5.1.25-rc-debug	OS:	Linux (SUSE 10 \| 32-bit)
Assigned to:	Mattias Jonsson	CPU Architecture:	Any

Description:
I complain about the following partition-related
error messages, which I notice in errmsg.sys.

"More partitions to reorganise than there are partitions"
"REORGANISE PARTITION can only be used to reorganise partitions not to change their numbers"
"REORGANISE PARTITION without parameters can only be used on auto-partitioned tables using HASH PARTITIONs"
"When reorganising a set of partitions they must be in consecutive order"
MySQL uses American spelling in the manual, so "reorganize" not "reorganise".

"Foreign key condition is not yet supported in conjunction with partitioning"
Say "clause" not "condition".
And make sure to use this error message when somebody tries to
use a foreign key / partition combination; do not use
"...". 

How to repeat:
mysql> create table tp (s1 int, foreign key (s1) references tp0 (s1)) engine=myisam
partition by hash (s1);
ERROR 1215 (HY000): Cannot add foreign key constraint

Thank you for the bug report. Verified as described.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48981

2693 Mattias Jonsson	2008-07-03
      Bug#36001 Partitions: spelling and using some error messages
      
      Changed error message to show that it is partitioning
      that does not support foreign keys yet.
      
      Changed spelling from British english to American english.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/60319

2770 Mattias Jonsson	2008-12-01
      pre push fix for bug#36001
      
      Fixed additional test results

pushed into mysql-6.0-bugteam

"REORGANISE PARTITION without parameters can only be used on auto-partitioned tables using HASH PARTITIONs" would be better worded as:

"REORGANIZE PARTITION without parameters can only be used on auto-partitioned tables using HASH partitioning"

Note that attempting to use 'REORGANISE PARTITION' results in a syntax error.

This fix also needs to go into 5.1 and 5.1-telco-6.* trees, please.

Thanks!

Pushed into 6.0.10-alpha (revid:joro@sun.com-20090119171328-2hemf2ndc1dxl0et) (version source revid:azundris@mysql.com-20081230114916-c290n83z25wkt6e4) (merge vers: 6.0.9-alpha) (pib:6)

Documented in the 6.0.10 changelog as follows:

        Several error messages relating to partitioned tables were
        incorrect or missing.

As discussed in my previous comments, I'm resetting this bug to Open and asking for a review with a mind to applying this fix in the 5.1-main and 5.1-telco-6.{2,3,4} trees. The issue with REORGANIZE PARTITION (and no options following) is particularly important for telco-6.4 - this form of the statement is critical for successful online add nodes functionality introduced in telco-6.4.

Thanks!

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/66798

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/66799

2803 Mattias Jonsson	2009-02-18
      Backport of bug#36001 from 6.0 to 5.1

Backported and pushed to 5.1 too.

Pushed into 5.1.33 (revid:joro@sun.com-20090313111355-7bsi1hgkvrg8pdds) (version source revid:azundris@mysql.com-20090224070618-mr7stu6rfcvoj18g) (merge vers: 5.1.33) (pib:6)

Changelog entry also added to 5.1.33 changelog.

(Cluster trees will pick this up with the next main->telco merges.)

Closed.

Pushed into 6.0.11-alpha (revid:joro@sun.com-20090318122208-1b5kvg6zeb4hxwp9) (version source revid:azundris@mysql.com-20090223123708-n9rf2to3g15br7za) (merge vers: 6.0.10-alpha) (pib:6)

Pushed into 5.1.34-ndb-6.2.18 (revid:jonas@mysql.com-20090508185236-p9b3as7qyauybefl) (version source revid:jonas@mysql.com-20090508100057-30ote4xggi4nq14v) (merge vers: 5.1.33-ndb-6.2.18) (pib:6)

Pushed into 5.1.34-ndb-6.3.25 (revid:jonas@mysql.com-20090509063138-1u3q3v09wnn2txyt) (version source revid:jonas@mysql.com-20090508175813-s6yele2z3oh6o99z) (merge vers: 5.1.33-ndb-6.3.25) (pib:6)

Pushed into 5.1.34-ndb-7.0.6 (revid:jonas@mysql.com-20090509154927-im9a7g846c6u1hzc) (version source revid:jonas@mysql.com-20090509073226-09bljakh9eppogec) (merge vers: 5.1.33-ndb-7.0.6) (pib:6)