Bug #34965 Online backup table has incorrect column name
Submitted: 29 Feb 2008 21:54 Modified: 11 Aug 2008 23:33
Reporter: Chuck Bell Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Backup Severity:S4 (Feature request)
Version:6.0.5 OS:Any
Assigned to: Chuck Bell CPU Architecture:Any

[29 Feb 2008 21:54] Chuck Bell
Description:
The mysql.online_backup table incorrectly displays 'engine' for the 'driver' column. This column refers to the backup (restore) drivers used in the operation. Comments for the column may also require changes.

How to repeat:
SELECT * FROM mysql.online_backup \G

*************************** 28. row ***************************
          backup_id: 28
         process_id: 0
...
host_or_server_name: localhost
           username: root
        backup_file: no_data4.bak
       user_comment:
            command: restore from 'no_data4.bak'
            engines: Nodata, Snapshot, Default    <------ error!

*************************** 1. row ***************************
       Table: online_backup
Create Table: CREATE TABLE `online_backup` (
  `backup_id` bigint(20) unsigned NOT NULL AUTO_INCREMENT COMMENT 'Surrogate key
 for (near) duplicate entries',
...
  `engines` varchar(100) DEFAULT NULL COMMENT 'The name of the storage engines u
                                                               ^^^^^^^^^^^^^^^
                                                                   Error!
sed in the operation',
  PRIMARY KEY (`backup_id`)
) ENGINE=MyISAM AUTO_INCREMENT=29 DEFAULT CHARSET=latin1

Suggested fix:
Change column name to 'driver' and fix comments.
[17 Jun 2008 11:31] Chuck Bell
This bug report is being satisfied as part of WL#4296.
[2 Jul 2008 20:45] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48914

2649 Chuck Bell	2008-07-02
      BUG#34965 Online backup table has incorrect column name 
      
      Changes name of column in mysql.online_backup from 'engines' to 'drivers'.
[2 Jul 2008 20:45] Chuck Bell
Patch ready for review.

http://lists.mysql.com/commits/48914
[3 Jul 2008 5:57] Rafal Somla
Good to push.
[8 Jul 2008 8:09] Ingo Strüwing
Ok to push. IMHO for just renaming something like this, one review would be sufficient.
[9 Jul 2008 18:38] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/49343

2657 Chuck Bell	2008-07-09
      BUG#34965 Online backup table has incorrect column name 
      
      Changes name of column in mysql.online_backup from 'engines' to 'drivers'.
[9 Jul 2008 18:47] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/49344

2657 Chuck Bell	2008-07-09
      BUG#34965 Online backup table has incorrect column name 
      
      Changes name of column in mysql.online_backup from 'engines' to 'drivers'.
[9 Jul 2008 18:48] Chuck Bell
Patch queued to mysql-6.0-backup-merge tree which will be pushed to mysql-6.0-backup tree soon.
[10 Jul 2008 12:21] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/49428

2658 Vladislav Vaintroub	2008-07-10
      Fix build error - generic-msvc-h does not compile in C++
[8 Aug 2008 13:35] Chuck Bell
Patch is in main.
[8 Aug 2008 16:29] Chuck Bell
Fix was pushed into 6.0.6.
[11 Aug 2008 23:33] Paul DuBois
Noted in 6.0.6 changelog.

The engines column in the mysql.online_backup table has been renamed
to drivers to better reflect its contents.
[14 Sep 2008 1:07] Bugs System
Pushed into 6.0.7-alpha  (revid:cbell@mysql.com-20080709183742-58qtf8cpkovbqpd6) (version source revid:vvaintroub@mysql.com-20080804094710-jb2qpqxpf2ir2gf3) (pib:3)