Bug #34892 | Transaction handling in select_create::abort let's Falcon fail | ||
---|---|---|---|
Submitted: | 27 Feb 2008 16:34 | Modified: | 9 Jan 2009 14:11 |
Reporter: | Alexander Nozdrin | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | MySQL Server: Falcon storage engine | Severity: | S1 (Critical) |
Version: | 6.0-runtime | OS: | Any |
Assigned to: | Sergey Vojtovich | CPU Architecture: | Any |
Tags: | pushbuild, test failure |
[27 Feb 2008 16:34]
Alexander Nozdrin
[27 Feb 2008 17:39]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/43091 ChangeSet@1.2577, 2008-02-27 20:40:21+03:00, anozdrin@quad. +1 -0 Disable failing tests (Bug#34892).
[27 Feb 2008 21:54]
Sveta Smirnova
Failure of falcon_bug_28095_II confirmed on 32-bit Linux.
[3 Mar 2008 18:18]
Bugs System
Pushed into 6.0.5-alpha
[4 Mar 2008 16:55]
Hakan Küçükyılmaz
This does not happen in the current mysql-6.0-falcon tree. However, in the latest mysql-6.0 tree we get this error: SET @@storage_engine = 'Falcon'; DROP TABLE IF EXISTS t1; SET @@autocommit = 0; CREATE TABLE t1 (PRIMARY KEY (a)) SELECT 1 AS a UNION ALL SELECT 1; -- ERROR 23000: Duplicate entry '1' for key 'PRIMARY' CREATE TABLE t1 (a int); DROP TABLE t1; -- CREATE TABLE t1 (a int)' failed: 1005: Can't create table 'test.t1' (errno: 156) After merging mysql-6.0 into mysql-6.0-falcon tree, the above sequence also fails in mysql-6.0-falcon tree.
[4 Mar 2008 17:01]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/43405 ChangeSet@1.2583, 2008-03-04 17:59:46+01:00, hakank@lu0011.(none) +2 -0 Test case to demonstrate failure in Bug #34892.
[5 Mar 2008 11:04]
Hakan Küçükyılmaz
See also Bug#35055
[7 Mar 2008 9:52]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/43569 ChangeSet@1.2587, 2008-03-07 10:52:41+01:00, hakank@lu0011.(none) +1 -0 Disabling falcon_bug_23945.test due to Bug# 34892.
[7 Mar 2008 11:39]
Bugs System
Pushed into 6.0.5-alpha
[7 Mar 2008 15:06]
Hakan Küçükyılmaz
Changed synopsis to reflect actual problem.
[12 Mar 2008 23:02]
Bugs System
Pushed into 6.0.4-alpha
[13 Mar 2008 16:00]
Hakan Küçükyılmaz
This bug is still open and in progress.
[15 Mar 2008 20:18]
Jim Starkey
The problem is that the server isn't calling savepoint_rollback after the failed write_row. This leaves uncommitted record in the transaction which, in turn, causes the drop table to fail. The server comments suggests that the intention was to rollback the savepoint; however, the code doesn't do it. This is a particularly egregious because the table is deleted in the server but not Falcon, making it impossible to either delete or re-create the table.
[17 Jul 2008 14:11]
Kevin Lewis
Sergey, Can you take a look at this to see how hard it would be to do in the server? The category is Server::General, but it prevents falcon_bug_23945 from working and it is a 6.0 bug. I am changing the category back to Falcon so we can track it better. Let me know if you need help from a server guru.
[11 Sep 2008 4:26]
Kevin Lewis
Bug#39157 was opened and marked as a duplicate of this one. Please see Bug#39157 for another easy testcase. When this is fixed, please try that testcase also.
[25 Sep 2008 14:40]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/54523 2832 Sergey Vojtovich 2008-09-25 BUG#34892 - Transaction handling in select_create::abort let's Falcon fail CREATE ... SELECT that fails (e.g. due to duplicate key) with Falcon storage engine prevents to create or drop a table with the same name in future. Added missing call to trans_rollback_stmt(), which was likely lost during merge.
[26 Sep 2008 13:11]
Kevin Lewis
Patch reviewed, OK to push
[29 Sep 2008 9:36]
Sergey Vojtovich
Back to In progress, as the patch introduces extra binlog event for failed CREATE ... SELECT, which should never happen.
[29 Sep 2008 18:37]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/54690 2842 Sergey Vojtovich 2008-09-29 BUG#34892 - Transaction handling in select_create::abort let's Falcon fail CREATE ... SELECT that fails (e.g. due to duplicate key) with Falcon storage engine prevents to create or drop a table with the same name in future. Added missing call to trans_rollback_stmt(), which was likely lost during merge.
[2 Oct 2008 10:38]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/55044 2842 Sergey Vojtovich 2008-10-02 BUG#34892 - Transaction handling in select_create::abort let's Falcon fail CREATE ... SELECT that fails (e.g. due to duplicate key) with Falcon storage engine prevents to create or drop a table with the same name in future. Added missing trans_rollback_stmt(), which was removed by accident by patch for BUG#12713.
[9 Jan 2009 14:11]
MC Brown
A noter has been added to the 6.0.8 changelog: Creating a new Falcon table using CREATE TABLE ... SELECT where the table uses a primary key, and rows contain duplicate keys, could lead to a table being created but not populated. Because the pending (bad) record was not committed, the table remains in a state that means it cannot be dropped or recreated.