MySQL Bugs: #34337: Server crash when Altering a view using a table name

Bug #34337	Server crash when Altering a view using a table name
Submitted:	6 Feb 2008 1:37	Modified:	15 Mar 2008 9:18
Reporter:	Omer Barnir (OCA)	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Views	Severity:	S3 (Non-critical)
Version:	5.1.23	OS:	Any
Assigned to:	Alexander Nozdrin	CPU Architecture:	Any

Description:
If trying to use alter view but specifying an object that is a table, the server crashes

Example:

Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 1
Server version: 5.1.23-rc-advanced-gpl-log MySQL Advanced Server (GPL)

Type 'help;' or '\h' for help. Type '\c' to clear the buffer.

mysql> create database omer1;
Query OK, 1 row affected (0.00 sec)

mysql> use omer1
Database changed

mysql> create table ttt (i int);
Query OK, 0 rows affected (0.01 sec)

mysql> ALTER ALGORITHM=TEMPTABLE SQL SECURITY INVOKER VIEW ttt (d) AS SELECT (1);
ERROR 2013 (HY000): Lost connection to MySQL server during query
mysql>                                                                  

The problem is not observed in 5.1.22 where an error:
ERROR 1347 (HY000): 'omer1.ttt' is not VIEW
is returned as expected

How to repeat:
Follow the above

Suggested fix:
Return the error as in 5.1.22

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42331

ChangeSet@1.2552, 2008-02-15 12:01:11+03:00, anozdrin@quad. +3 -0
  Fix for Bug#34337: Server crash when Altering a view using
  a table name.
  
  The problem was that in some cases lex->definer->user and
  lex->definer->host are NULL, but they were still passed
  to strcmp-functions.
  
  The fix is to check for NULL before passing strings.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42636

ChangeSet@1.2561, 2008-02-20 15:00:07+03:00, anozdrin@quad. +3 -0
  Fix for Bug#34337: Server crash when Altering a view using
  a table name.
  
  The problem was that fill_defined_view_parts() did not return
  an error if a table is going to be altered. That happened if
  the table was already in the table cache. In that case,
  open_table() returned non-NULL value (valid TABLE-instance from
  the cache).
  
  The fix is to ensure that an error is thrown even if the table
  is in the cache.

Second review sent by mail.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42688

ChangeSet@1.2561, 2008-02-20 22:23:39+03:00, anozdrin@quad. +3 -0
  Fix for Bug#34337: Server crash when Altering a view using
  a table name.
  
  The problem was that fill_defined_view_parts() did not return
  an error if a table is going to be altered. That happened if
  the table was already in the table cache. In that case,
  open_table() returned non-NULL value (valid TABLE-instance from
  the cache).
  
  The fix is to ensure that an error is thrown even if the table
  is in the cache.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42735

ChangeSet@1.2582, 2008-02-21 12:17:32+03:00, anozdrin@quad. +5 -0
  Fix for Bug#34337: Server crash when Altering a view using
  a table name.
    
  The problem was that fill_defined_view_parts() did not return
  an error if a table is going to be altered. That happened if
  the table was already in the table cache. In that case,
  open_table() returned non-NULL value (valid TABLE-instance from
  the cache).
    
  The fix is to ensure that an error is thrown even if the table
  is in the cache.
  
  (This is a backport of the original patch for 5.1)

Pushed into 5.0-runtime.

Pushed into 5.0.58

Pushed into 5.1.24-rc

Pushed into 6.0.5-alpha

Documented bugfix in the 5.0.58, 5.1.24, and 6.0.5 changelogs as follows:

        Executing an ALTER VIEW statement on a table crashed the server.

Also noted in the 5.1.23-ndb-6.3.11 changelog.