Bug #32115 | Bad use of Name_resolution_context from current LEX in partitioning | ||
---|---|---|---|
Submitted: | 5 Nov 2007 14:59 | Modified: | 7 Mar 2010 18:50 |
Reporter: | Ingo Strüwing | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | MySQL Server: Partitions | Severity: | S2 (Serious) |
Version: | 5.5.0 | OS: | Any |
Assigned to: | Mattias Jonsson | CPU Architecture: | Any |
[5 Nov 2007 14:59]
Ingo Strüwing
[27 Nov 2008 15:41]
Konstantin Osipov
Since it was agreed that in 6.0 we do not have a dependency between LEX and open_tables, I'm removing this assert from 6.0: === modified file 'sql/sql_base.cc' --- sql/sql_base.cc 2008-11-18 19:41:51 +0000 +++ sql/sql_base.cc 2008-11-27 15:31:04 +0000 @@ -2347,9 +2347,6 @@ bool open_table(THD *thd, TABLE_LIST *ta TABLE_SHARE *share; DBUG_ENTER("open_table"); - /* Parsing of partitioning information from .frm needs thd->lex set up. */ - DBUG_ASSERT(thd->lex->is_lex_started); - *action= OT_NO_ACTION; /* an open table operation needs a lot of the stack space */ In other words, this bug *must* be fixed in 6.0, otherwise we'll get regressions.
[27 Nov 2008 16:37]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/60079 2755 Konstantin Osipov 2008-11-27 Bug#32115 will remove the pre-requisite to initialize LEX to open tables. This dependency was added in 5.1 and was supposed to be removed in 6.0. Remove asserts and initialization of LEX in places where we don't deal with partitioned tables.
[8 Dec 2008 21:38]
Bugs System
Pushed into 6.0.9-alpha (revid:kostja@sun.com-20081127163609-6da53ewn1h3r1k7h) (version source revid:kostja@sun.com-20081127163609-6da53ewn1h3r1k7h) (pib:5)
[29 Jul 2009 14:02]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/79533 3477 Mikael Ronstrom 2009-07-29 Bug#32115, made use of local lex object to avoid side effects of opening partitioned tables modified: sql/sql_partition.cc
[29 Jul 2009 14:56]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/79536 3478 Mikael Ronstrom 2009-07-29 Bug#32115, added an extra test in debug builds to ensure no dangling pointers to the old lex object is still around modified: sql/sql_partition.cc
[29 Jul 2009 18:01]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/79552 3479 Mikael Ronstrom 2009-07-29 Bug#32115, Removed an assert that was no longer needed modified: sql/table.cc
[5 Aug 2009 12:53]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/80156 3480 Mikael Ronstrom 2009-08-05 Bug#32115, fixed review comments modified: sql/sql_partition.cc
[7 Aug 2009 9:43]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/80340 3481 Mikael Ronstrom 2009-08-07 Bug#32115, remove now obsolete lex_start calls modified: libmysqld/lib_sql.cc sql/event_data_objects.cc sql/ha_ndbcluster.cc sql/ha_ndbcluster_binlog.cc sql/slave.cc sql/sql_insert.cc sql/sql_partition.cc
[11 Aug 2009 13:04]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/80581 3526 Mattias Jonsson 2009-08-11 [merge] merge of bug#32115
[12 Aug 2009 22:17]
Mattias Jonsson
Checked for crashes as in both bug#31210 and bug#40281 before pushing into mysql-pe
[14 Sep 2009 16:05]
Bugs System
Pushed into 5.4.4-alpha (revid:alik@sun.com-20090914155317-m1g9wodmndzdj4l1) (version source revid:alik@sun.com-20090914155317-m1g9wodmndzdj4l1) (merge vers: 5.4.4-alpha) (pib:11)
[15 Sep 2009 9:13]
Jon Stephens
Documented bugfix in the 5.4.4 changelog as follows: Portions of the partitioning code were refactored in response to potential regression issues uncovered while working on the fix for Bug #31210. Closed.
[6 Nov 2009 22:41]
Marc ALFF
The fix for this bug has been documented for 5.4.4, but the code changed is not present in mysql-next-mr (5.5.0). In particular, DBUG_ASSERT(thd->lex->is_lex_started) is still present, and the various lex_start() calls that were removed with patches attached to this bug report are still present in the code. Changing the bug status to verified.
[19 Nov 2009 23:16]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/91001 2956 Mattias Jonsson 2009-11-20 Bug#32115: Bad use of Name_resolution_context from current LEX in partitioning port from mysql-next (5.4) to mysql-next-mr-bugfixing (5.5/5.6?) 2755 Konstantin Osipov 2008-11-27 Bug#32115 will remove the pre-requisite to initialize LEX to open tables. This dependency was added in 5.1 and was supposed to be removed in 6.0. Remove asserts and initialization of LEX in places where we don't deal with partitioned tables. @ sql/sp_head.cc Fix a typo.
[20 Nov 2009 0:21]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/91007 2957 Mattias Jonsson 2009-11-20 Bug#32115: Bad use of Name_resolution_context from current LEX in partitioning port from mysql-next (5.4?) to mysql-next-mr-bugfixes (5.5/5.6?) 3477 Mikael Ronstrom 2009-07-29 Bug#32115, made use of local lex object to avoid side effects of opening partitioned tables 3478 Mikael Ronstrom 2009-07-29 Bug#32115, added an extra test in debug builds to ensure no dangling pointers to the old lex object is still around 3479 Mikael Ronstrom 2009-07-29 Bug#32115, Removed an assert that was no longer needed 3480 Mikael Ronstrom 2009-08-05 Bug#32115, fixed review comments 3481 Mikael Ronstrom 2009-08-07 Bug#32115, remove now obsolete lex_start calls
[23 Nov 2009 11:18]
Mattias Jonsson
pushed to mysql-next-mr-bugfixing
[11 Dec 2009 6:02]
Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20091211055901-yp18b3c7xuhl87rf) (version source revid:alik@sun.com-20091211055401-43rjwq7gjed6ds83) (merge vers: 6.0.14-alpha) (pib:13)
[11 Dec 2009 6:03]
Bugs System
Pushed into 5.6.0-beta (revid:alik@sun.com-20091211055628-ltr7fero363uev7r) (version source revid:alik@sun.com-20091211055453-717czhtezc74u8db) (merge vers: 5.6.0-beta) (pib:13)
[11 Dec 2009 14:30]
Jon Stephens
Also noted in the 5.6.0 and 6.0.14 changelogs.
[11 Dec 2009 14:31]
Jon Stephens
Was this ever pushed to 5.5?
[12 Dec 2009 0:57]
Mattias Jonsson
No, I have not pushed this to mysql-trunk and I just verified that the patch is not there (5.5.0-beta according to configure.in).
[12 Dec 2009 8:03]
Jon Stephens
Hi! Thanks for confirming (my skills with bzr are not the greatest). Looks like it *should* go into 5.5 (P2/S2/D1/W1), but I'm closing for now to get it off my dashboard. It should get automatically set back to Documenting whenever it gets pushed to another tree; I'll add the appropriate changelog entry when that happens.
[6 Mar 2010 11:05]
Bugs System
Pushed into 5.5.3-m3 (revid:alik@sun.com-20100306103849-hha31z2enhh7jwt3) (version source revid:vvaintroub@mysql.com-20091211201717-03qf8ckwiw0np80p) (merge vers: 5.6.0-beta) (pib:16)
[7 Mar 2010 18:50]
Paul DuBois
Moved 5.6.0 changelog entry to 5.5.3.