Bug #29836 enable-pstack option appears even if --with-pstack is disabled
Submitted: 17 Jul 2007 4:03 Modified: 25 Jan 2008 19:36
Reporter: Sadao Hiratsuka (Basic Quality Contributor) Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:5.0.42 OS:Linux
Assigned to: CPU Architecture:Any
Tags: --with-pstack, enable-pstack, qc

[17 Jul 2007 4:03] Sadao Hiratsuka 
Description:
enable-pstack option appears even if --with-pstack is disabled.

[Enterprise]
MySQL Enterprise does not include pstack library because pstack is under GPL.
so I think this option should not appear.

[Community]
MySQL Community Edition can include pstack library.
But even if --with-pstack is disabled,
enable-pstack option appears in help message.

How to repeat:
$ /usr/sbin/mysqld --help --verbose
/usr/sbin/mysqld  Ver 5.0.42-enterprise for pc-linux-gnu on i686 (MySQL Enterprise Server (Commercial))
Copyright (C) 2000 MySQL AB, by Monty and others
This is commercial software, and use of this software is governed
by your applicable license agreement with MySQL
...
  --enable-pstack     Print a symbolic stack trace on failure.
...

Suggested fix:
Here is a sample fix.

*** mysqlcom-5.0.42/sql/mysqld.cc       2007-05-14 23:28:52.000000000 +0900
--- mysqlcom-5.0.42p/sql/mysqld.cc      2007-07-17 11:50:50.000000000 +0900
***************
*** 4955,4963 ****
--- 4955,4965 ----
     (gptr*) &opt_enable_named_pipe, (gptr*) &opt_enable_named_pipe, 0, GET_BOOL,
     NO_ARG, 0, 0, 0, 0, 0, 0},
  #endif
+ #ifdef HAVE_STACK_TRACE_ON_SEGV
    {"enable-pstack", OPT_DO_PSTACK, "Print a symbolic stack trace on failure.",
     (gptr*) &opt_do_pstack, (gptr*) &opt_do_pstack, 0, GET_BOOL, NO_ARG, 0, 0,
     0, 0, 0, 0},
+ #endif
    {"engine-condition-pushdown",
     OPT_ENGINE_CONDITION_PUSHDOWN,
     "Push supported query conditions to the storage engine.",
[11 Dec 2007 21:52] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/39754

ChangeSet@1.2681, 2007-12-11 16:52:17-05:00, dkatz@damien-katzs-computer.local +1 -0
  Bug #29836	enable-pstack option appears even if --with-pstack is disabled
  
  Placed all pstack code inside of #ifdef's, so the options aren't displayed when not available.
[25 Jan 2008 12:35] Bugs System 
Pushed into 5.1.24-rc
[25 Jan 2008 12:39] Bugs System 
Pushed into 6.0.5-alpha
[25 Jan 2008 19:36] Paul DuBois 
Noted in 5.1.24, 6.0.5 changelogs.

mysqld displayed the --enable-pstack option in its help message even
if MySQL was configured without --with-pstack.
[6 Mar 2008 9:00] Jon Stephens 
Also documented for 5.1.23-ndb-6.2.14.
[30 Mar 2008 17:39] Jon Stephens 
Also documented for 5.1.23-ndb-6.3.11.