MySQL Bugs: #29275: Messages from ndb_mgm are missleading / incorrect

Bug #29275	Messages from ndb_mgm are missleading / incorrect
Submitted:	21 Jun 2007 16:11	Modified:	19 Feb 2009 10:27
Reporter:	Matthew Montgomery	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Cluster: Cluster (NDB) storage engine	Severity:	S3 (Non-critical)
Version:	5.1.18	OS:	Any
Assigned to:	li zhou	CPU Architecture:	Any
Tags:	NDB_MGM

Description:
When restarting either ndbd or ndb_mgmd from within ndb_mgm you see the following message 

Shutting down nodes with "-n, no start" option, to subsequently start the nodes.
Node 1 is being restarted

This is not relevant to MGMD node restarts as there is no "-n no start" option for ndb_mgmd.  This message may alarm users into thinking that the cluster or data nodes are being restarted since word "nodes" is used. This can cause confusion.

The message presented when MGM node restarts should be more pertinent to ndb_mgmd's behavior.

How to repeat:
ndb_mgm> show
Connected to Management Server at: localhost:1186
Cluster Configuration
---------------------
[ndbd(NDB)]     2 node(s)
id=2    @127.0.0.1  (Version: 5.1.18, Nodegroup: 0)
id=3    @127.0.0.1  (Version: 5.1.18, Nodegroup: 0, Master)

[ndb_mgmd(MGM)] 1 node(s)
id=1    @127.0.0.1  (Version: 5.1.18)

[mysqld(API)]   2 node(s)
id=4 (not connected, accepting connect from any host)
id=5 (not connected, accepting connect from any host)

ndb_mgm> 1 restart
Shutting down nodes with "-n, no start" option, to subsequently start the nodes.
Node 1 is being restarted

Suggested fix:
The message presented when MGM node restarts should be more pertinent to ndb_mgmd's behavior.

i.e. On MGM node restart the message should read:

Shutting down MGM node <id>, for restart.

Verified, the "-n no-restart" reference doesn't make any sense for management nodes

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/31793

ChangeSet@1.2477, 2007-07-30 13:51:31+00:00, lzhou@dev3-63.(none) +1 -0
  BUG#29275 Remove incorrect message when do restart

Bug23354 change the output like this:

===============================
ndb_mgm> 2 restart
Node 2: Node shutdown initiated
Node 2: Node shutdown completed, restarting.
Node 2: Is being restarted
Node 2: Is rejoining the cluster

ndb_mgm> Node 2: Started (version 5.0.42)

ndb_mgm> 2 restart -n
Shutting down nodes with "-n, no start" option, to subsequently start the nodes.
Node 2: Node shutdown initiated
Node 2: Node shutdown completed, restarting.
Node 2: Is being restarted
Node 2: No start
===================================

So "Shutting down nodes with "-n, no start" option, to subsequently start the nodes." seems have no meaning.

The new output is here:

=========

ndb_mgm> 2 restart
Node 2: Node shutdown initiated
Node 2: Node shutdown completed, restarting.
Node 2: Is being restarted
Node 2: Is rejoining the cluster

ndb_mgm> Node 2: Started (version 5.0.42)

ndb_mgm> 2 restart -n
Node 2: Node shutdown initiated
Node 2: Node shutdown completed, restarting.
Node 2: Is being restarted
Node 2: No star

The problem I see with this patch is that it re-introduces the ambiguity of going "N restart" and seeing "Node N: Shutting down".

To remove this being printed in the management server, the event message should be changed to indicate the type of shutdown.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/32534

ChangeSet@1.2477, 2007-08-15 13:41:46+00:00, lzhou@dev3-63.(none) +1 -0
  BUG#29275 Correct message when do restart

Review mail sent, please migrate patches to bzr clone for mysql-5.1-telco-6.3

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/61387

2792 Leonard Zhou	2008-12-11
      BUG#29275 Correct message when do restart

Pushed into 5.1.30-ndb-6.4.0  (revid:leonard@mysql.com-20081211081213-ckgsa87jtkpat6o7) (version source revid:leonard@mysql.com-20081212044510-9y7zj8txryz6y381) (pib:5)

Pushed into 5.1.30-ndb-6.3.20  (revid:leonard@mysql.com-20081211081213-ckgsa87jtkpat6o7) (version source revid:leonard@mysql.com-20081211081213-ckgsa87jtkpat6o7) (pib:5)

Documented bugfix in the NDB-6.3.20 and 6.4.0 changelogs as follows:

        Status messages shown in the management client when restarting 
        a management node were inappropriate and potentially misleading. 
        Now, when restarting a management node, the messages displayed 
        are as follows, where node_id is the management node's node ID:
        
ndb_mgm> node_id RESTART
Shutting down MGM node node_id for restart
Node node_id is being restarted

ndb_mgm>