| Bug #29228 | ndb_size.pl fails on FLOAT columns with comma in () | ||
|---|---|---|---|
| Submitted: | 20 Jun 2007 3:10 | Modified: | 15 Sep 2007 11:23 |
| Reporter: | Stewart Smith | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Cluster: Cluster (NDB) storage engine | Severity: | S3 (Non-critical) |
| Version: | 5.1 | OS: | Any |
| Assigned to: | Stewart Smith | CPU Architecture: | Any |
| Tags: | FLOAT, ndb_size.pl | ||
[15 Aug 2007 2:16]
Stewart Smith
no objections to patch, pushed to 5.1-ndb
[15 Aug 2007 6:36]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/32537 ChangeSet@1.2580, 2007-08-15 12:12:46+10:00, stewart@flamingspork.com +1 -0 [PATCH] Bug#29228 ndb_size.pl borks on float columns with comma in () Index: ndb-work/storage/ndb/tools/ndb_size.pl ===================================================================
[7 Sep 2007 9:50]
Jon Stephens
Documented in mysql-5.1.22-ndb-6.2.5 changelog, left in PQ for mainline push. Updated synopsis & tags.
[14 Sep 2007 16:25]
Bugs System
Pushed into 5.1.23-beta
[15 Sep 2007 11:23]
Jon Stephens
Thank you for your bug report. This issue has been committed to our source repository of that product and will be incorporated into the next release.
If necessary, you can access the source repository and build the latest available version, including the bug fix. More information about accessing the source trees is available at
http://dev.mysql.com/doc/en/installing-source.html
Also documented in 5.1.23 changelog.
Description: table with column float(6,2) makes ndb_size.pl bork. How to repeat: . Suggested fix: Monty, you get to review as you've patched it too now :) Index: ndb-work/storage/ndb/tools/ndb_size.pl =================================================================== --- ndb-work.orig/storage/ndb/tools/ndb_size.pl 2007-06-20 12:02:55.547885085 +1000 +++ ndb-work/storage/ndb/tools/ndb_size.pl 2007-06-20 12:03:38.046306932 +1000 @@ -510,6 +510,8 @@ sub do_table { {$col->dm(4)} elsif($type =~ /float/) { + my @sz= split ',', $size; + $size= $sz[0]+$sz[1]; if(!defined($size) || $size<=24) {$col->dm(4)} else