MySQL Bugs: #28769: Test case "innodb" fails with --skip-log-bin

Bug #28769	Test case "innodb" fails with --skip-log-bin
Submitted:	30 May 2007 9:34	Modified:	3 Jul 2007 19:52
Reporter:	Daniel Fischer	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Replication	Severity:	S2 (Serious)
Version:		OS:	Any
Assigned to:	Magnus Blåudd	CPU Architecture:	Any
Tags:	pbfail

Description:
Test case "innodb" fails if binlog is disabled:

innodb                         [ fail ]

Errors are (from /shared/home/df/mysql/build/mysql-5.0-build-work-nn/mysql-test/var/log/mysqltest-time) :
mysqltest: Result length mismatch
(the last lines may be the most important ones)
Below are the diffs between actual and expected results:
-------------------------------------------------------
*** r/innodb.result	Thu Apr 19 04:36:16 2007
--- r/innodb.reject	Wed May 30 12:26:35 2007
***************
*** 1642,1667 ****
  drop table t2, t1;
  show status like "binlog_cache_use";
  Variable_name	Value
! Binlog_cache_use	155
  show status like "binlog_cache_disk_use";
  Variable_name	Value
  Binlog_cache_disk_use	0
  create table t1 (a int) engine=innodb;
  show status like "binlog_cache_use";
  Variable_name	Value
! Binlog_cache_use	156
  show status like "binlog_cache_disk_use";
  Variable_name	Value
! Binlog_cache_disk_use	1
  begin;
  delete from t1;
#######################################################################
  commit;
  show status like "binlog_cache_use";
  Variable_name	Value
! Binlog_cache_use	157
  show status like "binlog_cache_disk_use";
  Variable_name	Value
! Binlog_cache_disk_use	1
  drop table t1;
  create table t1 (c char(10), index (c,c)) engine=innodb;
  ERROR 42S21: Duplicate column name 'c'
--- 1642,1667 ----
  drop table t2, t1;
  show status like "binlog_cache_use";
  Variable_name	Value
! Binlog_cache_use	0
  show status like "binlog_cache_disk_use";
  Variable_name	Value
  Binlog_cache_disk_use	0
  create table t1 (a int) engine=innodb;
  show status like "binlog_cache_use";
  Variable_name	Value
! Binlog_cache_use	0
  show status like "binlog_cache_disk_use";
  Variable_name	Value
! Binlog_cache_disk_use	0
  begin;
  delete from t1;
  commit;
  show status like "binlog_cache_use";
  Variable_name	Value
! Binlog_cache_use	0
  show status like "binlog_cache_disk_use";
  Variable_name	Value
! Binlog_cache_disk_use	0
  drop table t1;
  create table t1 (c char(10), index (c,c)) engine=innodb;
  ERROR 42S21: Duplicate column name 'c'
-------------------------------------------------------
Please follow the instructions outlined at
http://www.mysql.com/doc/en/Reporting_mysqltest_bugs.html
to find the reason to this problem and how to report this.

Result from queries before failure can be found in r/innodb.log

Aborting: innodb failed in default mode. To continue, re-run with '--force'.

How to repeat:
perl mysql-test-run.pl --mysqld=--skip-log-bin innodb

Suggested fix:
Simplest solution is skipping this test case when binlog is not available.

Can some MySQL AB replication expert please help: how to modify the test so that it is not run if --skip-binlog?

Regards,

Heikki

Will be fixed by patch for "Bug#28369 rpl test cases fail with binlog disabled"

We will remove the "source include/have_log_bin.inc" from innodb.test and move any tests in innodb.test that need binlog to a separate test  - probably binlog_innodb.test

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/29061

ChangeSet@1.2531, 2007-06-19 09:56:19+02:00, msvensson@pilot.(none) +4 -0
  Bug#28769 Test case "innodb" fails with --skip-log-bin
   - Move binlog related tests to binlog_innodb.test
   - Remove "source include/have_log_bin.inc" from innodb.test

Pushed into 5.1.20-beta

Pushed into 5.0.46

Test case change. No changelog entry needed.