| Bug #28477 | innodb assertion and crash during alter table to add/drop partitions | ||
|---|---|---|---|
| Submitted: | 16 May 2007 17:05 | Modified: | 10 Jul 2009 13:54 |
| Reporter: | Shane Bester (Platinum Quality Contributor) | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Partitions | Severity: | S1 (Critical) |
| Version: | 5.1.19, 5.1.17, 5.1.36 | OS: | Any |
| Assigned to: | Alexey Botchkov | CPU Architecture: | Any |
| Tags: | assertion, crash, innodb, partition | ||
[16 May 2007 17:05]
Shane Bester
[16 May 2007 17:32]
MySQL Verification Team
verified on suse 9.3 using latest 5.1-bk source.
[20 May 2007 13:47]
MySQL Verification Team
I'mnot sure this is really an innodb bug. It seems you cannot do an optimize/repair/rebuild of a partition with myisam tables either, as long as inserts are happening in another thread. set category to 'Partitioning' instead.
[21 May 2007 7:49]
MySQL Verification Team
when fixing the bugs, please use *this* testcase to verify your fixes work.
Attachment: bug28477.c (text/plain), 6.03 KiB.
[27 May 2007 13:12]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/27408 ChangeSet@1.2535, 2007-05-27 18:16:13+05:00, holyfoot@mysql.com +1 -0 Bug #28477 innodb assertion and crash during alter table to add/drop partition. The bug was repeated on MyISAM tables, so isn't InnoDB specific. The reason is that open_ltable() called in mysql_alter_table doesn't check if the opened table was modified by other thread before it was locked by mysql_lock_tables(). mysql_lock_tables() can signal that case by setting it's 'need_reopen' parameter to TRUE. So check for that parameter added.
[1 Jun 2007 15:03]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/27933 ChangeSet@1.2535, 2007-06-01 19:00:22+05:00, holyfoot@mysql.com +1 -0 Bug #28477 innodb assertion and crash during alter table to add/drop partition. The bug was repeated on MyISAM tables, so isn't InnoDB specific. Reason of the bug is that partition-related members of TABLE_SHARE wasn't properly updated after ALTER command. So if other thread doesn't reread frm file, and just uses cached SHARE, it uses wrong data
[1 Jun 2007 15:43]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/27940 ChangeSet@1.2535, 2007-06-01 19:44:09+05:00, holyfoot@mysql.com +3 -0 Bug #28477 innodb assertion and crash during alter table to add/drop partition. The bug was repeated on MyISAM tables, so isn't InnoDB specific. Reason of the bug is that partition-related members of TABLE_SHARE wasn't properly updated after ALTER command. So if other thread doesn't reread frm file, and just uses cached SHARE, it uses wrong data
[14 Jun 2007 18:59]
Bugs System
Pushed into 5.1.20-beta
[15 Jun 2007 9:24]
Jon Stephens
Thank you for your bug report. This issue has been committed to our source repository of that product and will be incorporated into the next release.
If necessary, you can access the source repository and build the latest available version, including the bug fix. More information about accessing the source trees is available at
http://dev.mysql.com/doc/en/installing-source.html
Documented bugfix in 5.1.20 changelog.
[10 Jul 2009 13:45]
Andrii Nikitin
Reopening as this looks not fixed in 5.1.36 with slightly different testcase (original testcase didn't produce stacktrace for me):
delimiter ;
drop procedure if exists `p1`;
delimiter //
create procedure `p1`(`num` int)
begin
declare `i` int default '0';
declare continue handler for sqlexception begin end;
repeat
drop table if exists `t1`;
create table `t1` (`a` char(255) primary key) engine=innodb partition by key () partitions 4;
start transaction;
select sleep(1);
alter table `t1` add partition partitions 1;
alter table `t1` coalesce partition 1;
select sleep(1);
set `i`=`i`+1;
until `i`>=`num` end repeat;
end //
delimiter ;
drop procedure if exists `p2`;
delimiter //
create procedure `p2`(`num` int)
begin
declare `i` int default '0';
declare `j` int default '0';
declare continue handler for sqlexception begin end;
repeat
start transaction;
set `j`=0;
repeat
replace into `t1` values (concat(`j`,`i`));
set `j`=`j`+1;
until `j`>=1000 end repeat;
commit;
set `i`=`i`+1;
until `i`>=`num` end repeat;
end //
delimiter ;
first connection calls p1(1000000), second calls p2(1000000000).
If mysql started without config file on Windows, it crashes with same stacktrace in 1 minute.
If started with
--innodb_flush_log_at_trx_commit=0 --innodb_doublewrite=0 --innodb_lock_wait_timeout=1 --innodb_file_per_table
then no crash, just following errors appear in log
090710 15:42:26 InnoDB: Error creating file '.\part\t1#p#p0#tmp#.ibd'.
090710 15:42:26 InnoDB: Operating system error number 80 in a file operation.
* Win32 error code 80: The file exists.
See also bug #45961 which is duplicate of this one.
[10 Jul 2009 13:53]
Andrii Nikitin
Stacktrace is little different, probably bug should be reclosed: InnoDB: Thread 1236 stopped in file G:\mysql-5.1.36-winbuild\mysql-advanced-gpl-5.1.36-build\storage\innobase\include\sync0sync.ic line 115 000000014033D320 mysqld.exe!row_get_mysql_key_number_for_index()[row0mysql.c:1677] 0000000140334DFB mysqld.exe!ha_innobase::info()[ha_innodb.cc:6224] 0000000140042917 mysqld.exe!ha_partition::info()[ha_partition.cc:4935] 000000014004ACD7 mysqld.exe!handler::get_dup_key()[handler.cc:2954] 000000014004E05F mysqld.exe!handler::print_error()[handler.cc:2612] 00000001401AD637 mysqld.exe!mysql_change_partitions()[sql_partition.cc:5102] 00000001401B45E7 mysqld.exe!fast_alter_partition_table()[sql_partition.cc:6354] 000000014020B93B mysqld.exe!mysql_alter_table()[sql_table.cc:6905] 00000001401A4AC4 mysqld.exe!mysql_execute_command()[sql_parse.cc:2861] 000000014013FBE8 mysqld.exe!sp_instr_stmt::exec_core()[sp_head.cc:2908] 0000000140143395 mysqld.exe!sp_lex_keeper::reset_lex_and_exec_core()[sp_head.cc:2735] 0000000140143596 mysqld.exe!sp_instr_stmt::execute()[sp_head.cc:2851] 0000000140144FC5 mysqld.exe!sp_head::execute()[sp_head.cc:1255] 000000014014638F mysqld.exe!sp_head::execute_procedure()[sp_head.cc:1983] 00000001401A7144 mysqld.exe!mysql_execute_command()[sql_parse.cc:4359] 00000001401A93A6 mysqld.exe!mysql_parse()[sql_parse.cc:5937] 00000001401AA0DA mysqld.exe!dispatch_command()[sql_parse.cc:1215] 00000001401AB1A7 mysqld.exe!do_command()[sql_parse.cc:854] 000000014024DE37 mysqld.exe!handle_one_connection()[sql_connect.cc:1127] 00000001402BF9A5 mysqld.exe!pthread_start()[my_winthread.c:85] 00000001403D34D7 mysqld.exe!_callthreadstart()[thread.c:295] 00000001403D35A5 mysqld.exe!_threadstart()[thread.c:275] 0000000077A1542D kernel32.dll!BaseThreadInitThunk() 0000000077B5BE51 ntdll.dll!RtlUserThreadStart() Trying to get some variables. Some pointers may be invalid and cause the dump to abort... thd->query at 0000000003759FE0=alter table `t1` add partition partitions 1 thd->thread_id=2 thd->killed=NOT_KILLED
[18 Jul 2009 3:24]
MySQL Verification Team
Hi Andrii, That stack trace is very much same as bug #45808.
