MySQL Bugs: #27739: build fails on Tru64 due to icheck test in configure

Bug #27739	build fails on Tru64 due to icheck test in configure
Submitted:	10 Apr 2007 23:49	Modified:	27 Apr 2007 17:17
Reporter:	Peter O'Gorman
Status:	Closed
Category:	Server: Compiling	Severity:	S3 (Non-critical)
Version:	5.0.38	OS:	Other (Tru64 5.1osf1)
Assigned to:	Joerg Bruehe	Target Version:
Tags:	Contribution

Description:
configure tests for icheck from debian to test abi changes, icheck on Tru64 lives in
/usr/sbin/icheck and is found by the configure test. Problem is that icheck on Tru64 is a
"File system storage consistency check". So the build fails when this icheck is given
options it does not understand.

How to repeat:
Build mysql-5.0/38 on Tru64

Suggested fix:
This patch to configure.in

@@ -459,6 +428,18 @@

 # icheck, used for ABI check
 AC_PATH_PROG(ICHECK, icheck, no)
+if test "x$ICHECK" != "xno"; then
+AC_MSG_CHECKING(if $ICHECK works as expected)
+echo "int foo;" > conftest.h
+$ICHECK --canonify -o conftest.ic conftest.h 2>/dev/null
+if ! test -f "conftest.ic" ;then
+AC_MSG_RESULT(no)
+ICHECK=no
+else
+AC_MSG_RESULT(yes)
+fi
+rm -f conftest.ic conftest.h
+fi
 AC_SUBST(ICHECK)

 # Lock for PS

Thank you for a bug report and patch.

I tried the proposed patch on both Debian (with "icheck" installed) and SuSE (without):
Patch works, no negative consequences.

I do not have access to a machine where "icheck" is a file system checker (like Tru64),
all our build hosts tah have any "icheck" have it as the ABI checker.
So I must leave that verification to the bug reporter (or some other user).
However, I trust that the reporter did this before proposing the patch.

I will soon commit it internally to get it reviewed.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/24978

ChangeSet@1.2459, 2007-04-20 10:51:53+02:00, joerg@debian.(none) +1 -0
  configure.in  :  Ensure that "icheck" is really the ABI checker,
                   not some other tool (file system checker on Tru64).
  
  Patch originally supplied by Peter O'Gorman, slightly modified by me.
  
  Bug#27739 "build fails on Tru64 due to icheck test in configure"

Pushed to the internal testing trees,
hopefully to be merged to the main trees next week.

Pushed into 5.1.18-beta

Pushed into 5.0.42

No changelog entry needed.