MySQL Bugs: #1661: Compiling --with-pstack fails with binutils 2.13.90

Bug #1661	Compiling --with-pstack fails with binutils 2.13.90
Submitted:	25 Oct 2003 5:49	Modified:	4 Mar 2004 6:32
Reporter:	Johan Backlund	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Compiling	Severity:	S3 (Non-critical)
Version:	4.x	OS:	Linux (RedHat 9)
Assigned to:	Victor Vagin	CPU Architecture:	Any

Description:
Compiling server with --with-pstack doesn't work with binutils 2.13.90 and later. Apparently, a typedef previously named boolean has been renamed bfd_boolean in binutils and this type is used in the pstack source. Also, the true/false values have been renamed to TRUE/FALSE.
I am not sure the exact binutils release that got this change. I am reporting it on the version I have got installed on my RedHat 9 system.

How to repeat:
Make sure you have binutils-2.13.90 or later installed. Configure your favorite MySQL 4.x source using the --with-pstack option and the make it.

Suggested fix:
Make the following changes in the pstack source:

boolean -> bfd_boolean
true -> TRUE
false -> FALSE

with a version guard macro based on the installed binutils version. I guess it could also be solved by introducing a local definition of boolean in the pstack which would be activated when a newer binutil package is used.

I got same resutl with binutils-2.14.90

$ rpm -q binutils
binutils-2.14.90.0.4-19

./configure --with-pstack
make

...

gcc -DHAVE_CONFIG_H -I. -I. -I.. -I./../include -I../include    -O3 -DDBUG_OFF  -c `test -f 'bucomm.c' || echo './'`bucomm.c
In file included from bucomm.c:26:
bucomm.h:66: error: parse error before "boolean"
bucomm.c: In function `print_arelt_descr':
bucomm.c:155: error: parse error before "boolean"

Thank you for your bug report. This issue has been committed to our
source repository of that product and will be incorporated into the
next release.

If necessary, you can access the source repository and build the latest
available version, including the bugfix, yourself. More information 
about accessing the source trees is available at
    http://www.mysql.com/doc/en/Installing_source_tree.html