Bug #12019 Unable to create DSN Files

Description:
When creating a file DSN using the My SQL ODBC driver I get an error message, 
"A connection could not be made using the file data source parameters entered.  -- Save nonverified file DSN?"

If I choose to sve the file, I can not open it later and I get an error message.  
"Invalid file dsn"

I am able to create System and User DSN connections.

How to repeat:
Open the Windows ODBC Administrative tool.  click on the file tab and then click add.  Follow the steps and the error appears after pressing finish.

Suggested fix:
This used to work in older version fo 3.5  I think I had been running version 9 but when we upgraded the server, I had to upgrade the client.

Tested on Win 2003

c/odbc support for file based DSN's is being reworked into our cross-platform layer and will be available in a future release.

Index: myodbc3/connect.c
===================================================================
--- myodbc3/connect.c	(revision 29)
+++ myodbc3/connect.c	(working copy)
@@ -602,15 +602,23 @@
         if ( !pFunc( hdbc, hwnd, pDataSource ) )
         {
             set_dbc_error( hdbc, "HY000", "User cancelled.", 0 );
-            nReturn = SQL_ERROR;
+            nReturn = pDataSource->bSaveFileDSN ? SQL_NO_DATA : SQL_ERROR;
             goto exitDriverConnect0;
         }
     }
 
     if ( my_SQLDriverConnectTry( dbc, pDataSource ) != SQL_SUCCESS )
     {
-        nReturn = SQL_ERROR;
-        goto exitDriverConnect0;
+        if (!pDataSource->bSaveFileDSN)
+        {
+          nReturn = SQL_ERROR;
+          goto exitDriverConnect0;
+        }
+        else
+        {
+          set_dbc_error( hdbc, "08001", "Client unable to establish connection.", 0 );
+          nReturn = SQL_SUCCESS_WITH_INFO;
+        }
     }
 
 exitDriverConnect1:
Index: myodbc3u/MYODBCUtil.h
===================================================================
--- myodbc3u/MYODBCUtil.h	(revision 29)
+++ myodbc3u/MYODBCUtil.h	(working copy)
@@ -184,6 +184,8 @@
     MYODBCUTIL_DATASOURCE_MODE      nMode;      /* ConfigDSN mode or SQLDriverConnect mode.                                     */
     MYODBCUTIL_DATASOURCE_CONNECT   nConnect;   /* SQLDriverConnect() using a DSN or a DRIVER to connect.                       */
     MYODBCUTIL_DATASOURCE_PROMPT    nPrompt;    /* SQLDriverConnect() kind of prompting (if any).                               */
+    
+    BOOL  bSaveFileDSN;         /* Flag specifying that SQLConnect was invoked as part of creation of a file DSN                */
 
 } MYODBCUTIL_DATASOURCE;
 
Index: myodbc3u/MYODBCUtilReadConnectStr.c
===================================================================
--- myodbc3u/MYODBCUtilReadConnectStr.c	(revision 29)
+++ myodbc3u/MYODBCUtilReadConnectStr.c	(working copy)
@@ -173,6 +173,10 @@
                             if ( !pDataSource->pszUSER )
                                 pDataSource->pszUSER = (char *)strndup( pAnchorChar, pScanChar - pAnchorChar );
                         }
+                        else if ( strcasecmp( pszName, "SAVEFILE" ) == 0 )
+                        {
+                          pDataSource->bSaveFileDSN = TRUE;
+                        }
                         else
                         {
                             /* What the ? */

Fix is available in 3.51.12

Noted in MyODBC 3.51.12 changelog.

        <para>
          File DSNs could not be saved. (Bug #12019)
        </para>

This still doesn't work for me in 3.51.12 under Windows XP (or 2000)